Skip to content

Commit

Permalink
fix: Add missing is_empty check for enums (#7257)
Browse files Browse the repository at this point in the history
  • Loading branch information
jfecher authored Jan 31, 2025
1 parent 0c6c637 commit a9e9850
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ impl CollectedItems {
pub fn is_empty(&self) -> bool {
self.functions.is_empty()
&& self.structs.is_empty()
&& self.enums.is_empty()
&& self.type_aliases.is_empty()
&& self.traits.is_empty()
&& self.globals.is_empty()
Expand Down

2 comments on commit a9e9850

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: a9e9850 Previous: 0c6c637 Ratio
noir-lang_eddsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: a9e9850 Previous: 0c6c637 Ratio
noir-lang_noir_string_search_ 1 s 0 s +∞
noir-lang_mimc_ 1 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Please sign in to comment.