Fix check_unsigned_overflow to not emit range check for mul by bool

noir-lang · Jan 8, 2025 · 744a872 · 744a872
1 parent 6eb09f7
commit 744a872
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/compiler/noirc_evaluator/src/acir/mod.rs b/compiler/noirc_evaluator/src/acir/mod.rs
@@ -2028,7 +2028,11 @@ impl<'a> Context<'a> {
                 "attempt to subtract with overflow".to_string()
             }
             BinaryOp::Mul => {
-                if bit_size == 1 || max_lhs_bits + max_rhs_bits <= bit_size {
+                if bit_size == 1
+                    || max_lhs_bits + max_rhs_bits <= bit_size
+                    || max_lhs_bits == 1
+                    || max_rhs_bits == 1
+                {
                     // Either performing boolean multiplication (which cannot overflow),
                     // or `lhs` and `rhs` have both been casted up from smaller types and so cannot overflow.
                     return Ok(());