Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix running Rust based tests #66

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR updates the wasm-bindgen-test test to run on nodejs rather than in a headless browser as there isn't one set up on the mainframe. I've also addressed an issue where at some point we started tripping a locals exceed maximum wasm error, increasing the level of optimisation in the dev profile optimizes these away so we can run the tests again.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from sirasistant July 10, 2023 12:09
@TomAFrench TomAFrench merged commit 92ada49 into master Jul 11, 2023
@TomAFrench TomAFrench deleted the fix-witness-map-test branch July 11, 2023 02:22
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
kobyhallx pushed a commit to noir-lang/acvm that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant