This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
feat!: Depend upon upstream barretenberg & switch to UltraPlonk #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c33b533
to
f561863
Compare
phated
reviewed
Apr 5, 2023
phated
reviewed
Apr 5, 2023
kevaundray
reviewed
Apr 6, 2023
kevaundray
reviewed
Apr 6, 2023
kevaundray
reviewed
Apr 6, 2023
kevaundray
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM -- I have left some comments but nothing blocking
TomAFrench
reviewed
Apr 6, 2023
This looks good to me. Can't approve my own request so commenting here |
Co-authored-by: Tom French <[email protected]>
5 tasks
kobyhallx
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
TomAFrench
added a commit
to TomAFrench/aztec_backend
that referenced
this pull request
Apr 6, 2023
* master: feat!: Depend upon upstream barretenberg & switch to UltraPlonk (noir-lang#84) feat: update `aztec_backend_wasm` to use new serialization (noir-lang#94) chore: update acvm to 0.8.0 (noir-lang#92) chore!: update to ACVM 0.7.0 (noir-lang#90)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates aztec_backend to using upstream barretenberg, and switches from using TurboPlonk to UltraPlonk.
To streamline the installation of upstream bb, we are using Nix. This has lead us to replace the CI with nix commands, but if we want to add pure cargo commands, we can add more jobs that install bb and its deps globally.