Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVC & Events methods #63

Closed
wants to merge 9 commits into from
Closed

PVC & Events methods #63

wants to merge 9 commits into from

Conversation

faust64
Copy link
Contributor

@faust64 faust64 commented May 12, 2018

couple methods I've been missing using that library.

@ghost ghost added the in progress label May 12, 2018
@faust64
Copy link
Contributor Author

faust64 commented May 12, 2018

--if I understand properly, tests are failing due to some vulnerable dependency being spotted by nsp
I did notice this setting it up over here, it shouldn't prevent tests from running, ...
AFAIU, a fix for this nsp error would be on its way ( see: TritonDataCenter/node-http-signature#68 )

@lholmquist lholmquist self-requested a review May 14, 2018 15:01
@lholmquist
Copy link
Member

let me fix that security issue and i'll let you know when to do a quick rebase

@lholmquist
Copy link
Member

@faust64 master now has a fix for that security issue, mind doing a rebase

@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage increased (+0.2%) to 97.677% when pulling 757bdaa on faust64:feat-pvc into 204f3a4 on bucharest-gold:master.

@faust64
Copy link
Contributor Author

faust64 commented May 14, 2018

perfect, thanks!

@lholmquist
Copy link
Member

@faust64 looks like your history got a little messy.

@lholmquist
Copy link
Member

@faust64 I cleaned up the history a bit and yours bits landed via this pr #68

Thanks!!

@lholmquist
Copy link
Member

Now in npm as 1.2.0

@lholmquist lholmquist closed this May 22, 2018
@ghost ghost removed the review label May 22, 2018
@faust64 faust64 deleted the feat-pvc branch February 8, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants