Skip to content
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.

renamed meeting notes #47

Merged
1 commit merged into from
Apr 2, 2018
Merged

renamed meeting notes #47

1 commit merged into from
Apr 2, 2018

Conversation

WaleedAshraf
Copy link
Contributor

renamed meeting notes to match format followed in all other Node.js repos.
This also helps with nodejs/community-committee#267

Right now https://nodejs-participation.herokuapp.com/nodejs/user-feedback.html shows invalid date, because of the different format.

Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good idea.

@dshaw dshaw requested review from a user and dshaw April 2, 2018 19:32
Copy link
Contributor

@dshaw dshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WaleedAshraf Thank you. I really appreciate this. I'm adding @mihaiep as a reviewer to make sure that he tunes into this requested change. LGTM.

@dshaw
Copy link
Contributor

dshaw commented Apr 2, 2018

@mihaiep If this passes your review, please go ahead and merge this.

@ghost ghost merged commit bc97094 into nodejs:master Apr 2, 2018
@ghost
Copy link

ghost commented Apr 2, 2018

merged. Thanks

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost pushed a commit that referenced this pull request Apr 2, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants