Add example for request + "Garbage Collection"
#3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WTCT-TOP
commented
Dec 2, 2024
|
It was added under the fetch specification compliance section. It should be moved elsewhere. |
mcollina
reviewed
Dec 2, 2024
|
@KhafraDev do you think I should move the whole GC section or just the new example for request? Also, is there a reason to |
yes exactly. Currently this allocates one promise too much ;).
If you don't await dump, you'll still have asynchronous activity happening in the background, as the body will not be dumped immediately. Not awaiting it defeats the purpose of the example, as without it there will be lingering memory and activity running. |
|
I've updated both examples to use async await, let me know what you think.. |
ToddyTheNoobDud
added a commit
to ToddyTheNoobDud/AquaLink
that referenced
this pull request
Dec 18, 2024
- This feature was implemented in undici 7.1.1, according to nodejs/undici#3916 (comment)
ToddyTheNoobDud
added a commit
to ToddyTheNoobDud/AquaLink
that referenced
this pull request
Dec 18, 2024
create-app-token-action-releaser bot
pushed a commit
to actions/create-github-app-token
that referenced
this pull request
Jan 30, 2025
## [1.11.2](v1.11.1...v1.11.2) (2025-01-30) ### Bug Fixes * **deps:** bump @octokit/request from 9.1.3 to 9.1.4 in the production-dependencies group ([#196](#196)) ([b4192a5](b4192a5)), closes [#730](https://github.com/actions/create-github-app-token/issues/730) [#730](https://github.com/actions/create-github-app-token/issues/730) [#729](https://github.com/actions/create-github-app-token/issues/729) [#727](https://github.com/actions/create-github-app-token/issues/727) [#726](https://github.com/actions/create-github-app-token/issues/726) [#723](https://github.com/actions/create-github-app-token/issues/723) [#724](https://github.com/actions/create-github-app-token/issues/724) [#722](https://github.com/actions/create-github-app-token/issues/722) [#721](https://github.com/actions/create-github-app-token/issues/721) [#720](https://github.com/actions/create-github-app-token/issues/720) [#719](https://github.com/actions/create-github-app-token/issues/719) * **deps:** bump undici from 6.19.8 to 7.2.0 ([#198](#198)) ([29aa051](29aa051)), closes [nodejs/undici#3958](nodejs/undici#3958) [nodejs/undici#3955](nodejs/undici#3955) [nodejs/undici#3962](nodejs/undici#3962) [nodejs/undici#3921](nodejs/undici#3921) [nodejs/undici#3923](nodejs/undici#3923) [nodejs/undici#3925](nodejs/undici#3925) [nodejs/undici#3926](nodejs/undici#3926) [nodejs/undici#3924](nodejs/undici#3924) [nodejs/undici#3933](nodejs/undici#3933) [nodejs/undici#3916](nodejs/undici#3916) [nodejs/undici#3930](nodejs/undici#3930) [nodejs/undici#3938](nodejs/undici#3938) [#3937](https://github.com/actions/create-github-app-token/issues/3937) [nodejs/undici#3940](nodejs/undici#3940) [nodejs/undici#3931](nodejs/undici#3931) [nodejs/undici#3941](nodejs/undici#3941) [nodejs/undici#3911](nodejs/undici#3911) [nodejs/undici#3888](nodejs/undici#3888) [nodejs/undici#3939](nodejs/undici#3939) [nodejs/undici#3947](nodejs/undici#3947) [nodejs/undici#3945](nodejs/undici#3945) [nodejs/undici#3916](nodejs/undici#3916) [nodejs/undici#3893](nodejs/undici#3893) [nodejs/undici#3902](nodejs/undici#3902) [#3901](https://github.com/actions/create-github-app-token/issues/3901) [nodejs/undici#3903](nodejs/undici#3903) [nodejs/undici#3905](nodejs/undici#3905) [nodejs/undici#3900](nodejs/undici#3900) [nodejs/undici#3913](nodejs/undici#3913) [nodejs/undici#3910](nodejs/undici#3910) [nodejs/undici#3909](nodejs/undici#3909) [nodejs/undici#3906](nodejs/undici#3906) [nodejs/undici#3922](nodejs/undici#3922) [#3962](https://github.com/actions/create-github-app-token/issues/3962) [#3955](https://github.com/actions/create-github-app-token/issues/3955) [#3958](https://github.com/actions/create-github-app-token/issues/3958) [#3945](https://github.com/actions/create-github-app-token/issues/3945) [#3947](https://github.com/actions/create-github-app-token/issues/3947) [#3939](https://github.com/actions/create-github-app-token/issues/3939) [#3888](https://github.com/actions/create-github-app-token/issues/3888) [#3911](https://github.com/actions/create-github-app-token/issues/3911) [#3941](https://github.com/actions/create-github-app-token/issues/3941)
bloopy-boi bot
added a commit
to h3mmy/bloopyboi
that referenced
this pull request
Jan 31, 2025
…→ v1.11.2 ) (#459) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/create-github-app-token](https://github.com/actions/create-github-app-token) | action | patch | `v1.11.1` -> `v1.11.2` | --- ### Release Notes <details> <summary>actions/create-github-app-token (actions/create-github-app-token)</summary> ### [`v1.11.2`](https://github.com/actions/create-github-app-token/releases/tag/v1.11.2) [Compare Source](https://github.com/actions/create-github-app-token/compare/v1.11.1...v1.11.2) ##### Bug Fixes - **deps:** bump [@​octokit/request](https://github.com/octokit/request) from 9.1.3 to 9.1.4 in the production-dependencies group ([#​196](https://github.com/actions/create-github-app-token/issues/196)) ([b4192a5](https://github.com/actions/create-github-app-token/commit/b4192a5b3659c0e5875f868c44727ef4ecc5d579)), closes [#​730](https://github.com/actions/create-github-app-token/issues/730) [#​730](https://github.com/actions/create-github-app-token/issues/730) [#​729](https://github.com/actions/create-github-app-token/issues/729) [#​727](https://github.com/actions/create-github-app-token/issues/727) [#​726](https://github.com/actions/create-github-app-token/issues/726) [#​723](https://github.com/actions/create-github-app-token/issues/723) [#​724](https://github.com/actions/create-github-app-token/issues/724) [#​722](https://github.com/actions/create-github-app-token/issues/722) [#​721](https://github.com/actions/create-github-app-token/issues/721) [#​720](https://github.com/actions/create-github-app-token/issues/720) [#​719](https://github.com/actions/create-github-app-token/issues/719) - **deps:** bump undici from 6.19.8 to 7.2.0 ([#​198](https://github.com/actions/create-github-app-token/issues/198)) ([29aa051](https://github.com/actions/create-github-app-token/commit/29aa0514a79f3b4aa8b1547173a41455949e4bf6)), closes [nodejs/undici#3958](https://github.com/nodejs/undici/issues/3958) [nodejs/undici#3955](https://github.com/nodejs/undici/issues/3955) [nodejs/undici#3962](https://github.com/nodejs/undici/issues/3962) [nodejs/undici#3921](https://github.com/nodejs/undici/issues/3921) [nodejs/undici#3923](https://github.com/nodejs/undici/issues/3923) [nodejs/undici#3925](https://github.com/nodejs/undici/issues/3925) [nodejs/undici#3926](https://github.com/nodejs/undici/issues/3926) [nodejs/undici#3924](https://github.com/nodejs/undici/issues/3924) [nodejs/undici#3933](https://github.com/nodejs/undici/issues/3933) [nodejs/undici#3916](https://github.com/nodejs/undici/issues/3916) [nodejs/undici#3930](https://github.com/nodejs/undici/issues/3930) [nodejs/undici#3938](https://github.com/nodejs/undici/issues/3938) [#​3937](https://github.com/actions/create-github-app-token/issues/3937) [nodejs/undici#3940](https://github.com/nodejs/undici/issues/3940) [nodejs/undici#3931](https://github.com/nodejs/undici/issues/3931) [nodejs/undici#3941](https://github.com/nodejs/undici/issues/3941) [nodejs/undici#3911](https://github.com/nodejs/undici/issues/3911) [nodejs/undici#3888](https://github.com/nodejs/undici/issues/3888) [nodejs/undici#3939](https://github.com/nodejs/undici/issues/3939) [nodejs/undici#3947](https://github.com/nodejs/undici/issues/3947) [nodejs/undici#3945](https://github.com/nodejs/undici/issues/3945) [nodejs/undici#3916](https://github.com/nodejs/undici/issues/3916) [nodejs/undici#3893](https://github.com/nodejs/undici/issues/3893) [nodejs/undici#3902](https://github.com/nodejs/undici/issues/3902) [#​3901](https://github.com/actions/create-github-app-token/issues/3901) [nodejs/undici#3903](https://github.com/nodejs/undici/issues/3903) [nodejs/undici#3905](https://github.com/nodejs/undici/issues/3905) [nodejs/undici#3900](https://github.com/nodejs/undici/issues/3900) [nodejs/undici#3913](https://github.com/nodejs/undici/issues/3913) [nodejs/undici#3910](https://github.com/nodejs/undici/issues/3910) [nodejs/undici#3909](https://github.com/nodejs/undici/issues/3909) [nodejs/undici#3906](https://github.com/nodejs/undici/issues/3906) [nodejs/undici#3922](https://github.com/nodejs/undici/issues/3922) [#​3962](https://github.com/actions/create-github-app-token/issues/3962) [#​3955](https://github.com/actions/create-github-app-token/issues/3955) [#​3958](https://github.com/actions/create-github-app-token/issues/3958) [#​3945](https://github.com/actions/create-github-app-token/issues/3945) [#​3947](https://github.com/actions/create-github-app-token/issues/3947) [#​3939](https://github.com/actions/create-github-app-token/issues/3939) [#​3888](https://github.com/actions/create-github-app-token/issues/3888) [#​3911](https://github.com/actions/create-github-app-token/issues/3911) [#​3941](https://github.com/actions/create-github-app-token/issues/3941) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDYuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE0Ni4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2IiwibGFiZWxzIjpbInJlbm92YXRlL2dpdGh1Yi1hY3Rpb24iLCJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: bloopy-boi[bot] <98279278+bloopy-boi[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
See #3914
Changes
Added an example for
request+ "Garbage Collection".Status