Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patched dom types (v6.x branch) #3531

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Remove patched dom types (v6.x branch) #3531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfdeac5
fix: Remove patched DOM types `Event` & `EventTarget`
eXhumer Sep 1, 2024
3701c06
better @types/node version lock
eXhumer Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
better @types/node version lock 
* Add minimum types for node based on `engines` version
* Currently undici locks engine to node@>=18.17
* Get @types/node for 18.17.x specificially and lock to patch upgrades only for 18.17

Signed-off-by: eXhumer <[email protected]>
  • Loading branch information
@eXhumer
eXhumer committed Sep 1, 2024
commit 3701c0643cce9be7c3373f39a22cf58d61d1783c
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"@fastify/busboy": "2.1.1",
"@matteo.collina/tspl": "^0.1.1",
"@sinonjs/fake-timers": "^11.1.0",
"@types/node": "^18.0.3",
"@types/node": "~18.17.19",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@eXhumer eXhumer Sep 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just provides type for node 18.17 specifically, which is the minimum required based on the engines version. The listed version ^18.0.3 doesn't contain the Event and EventTarget. And the version that ends up being installed installs typing related to node 18.19 (18.19.47) instead of the minimum supported 18.17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can revert back this change if necessary, but I strongly recommend locking the @types/node to the minimum supported version mentioned in engines.node in package.json.

"abort-controller": "^3.0.0",
"borp": "^0.15.0",
"c8": "^10.0.0",
Expand Down
Loading