Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instantiation of SecureProxyConnectionError should pass options to parent class #3473

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix: instantiation of SecureProxyConnectionError should pass options to parent class #3473

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb8e30b
fix: instantiation of SecureProxyConnectionError should pass options …
Uzlopak Aug 16, 2024
cdb7127
fix typescript error by making cause optional
Uzlopak Aug 16, 2024
c913b2e
fix ts error
Uzlopak Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typescript error by making cause optional
  • Loading branch information
@Uzlopak
Uzlopak committed Aug 16, 2024
commit cdb7127c01550ece41966a4ada1c5d8901e275ae
2 changes: 1 addition & 1 deletion types/errors.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@

export class SecureProxyConnectionError extends UndiciError {
constructor (
cause: Error,
cause?: Error,
message?: string,
options?: ErrorOptions

Check failure on line 149 in types/errors.d.ts

View workflow job for this annotation

GitHub Actions / Test TypeScript types 

Cannot find name 'ErrorOptions'.
);
name: 'SecureProxyConnectionError';
code: 'UND_ERR_PRX_TLS';
Expand Down
Loading