Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not include :status in the h2 fetch. #2416

Closed
wants to merge 5 commits into from
Closed

fix: Not include :status in the h2 fetch. #2416

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f71bb9
feat: add test
tsctx Nov 9, 2023
0669305
fix: test
tsctx Nov 9, 2023
e1e76b9
feat: add more test
tsctx Nov 9, 2023
e5ab3d5
feat: check pseudo-header
tsctx Nov 9, 2023
418bb16
fix: test
tsctx Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: check pseudo-header
  • Loading branch information
@tsctx
tsctx committed Nov 9, 2023
commit e5ab3d5f8edf81d9950cd570c9c881cc4b27a94f
6 changes: 4 additions & 2 deletions lib/fetch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,8 @@ async function httpNetworkFetch (
location = val
}

headers.append(key, val)
// Note: Not allow pseudo-header for H2. e.g. `:status`
if (key.charCodeAt(0) !== 58) headers.append(key, val)
}
} else {
const keys = Object.keys(headersList)
Expand All @@ -2016,7 +2017,8 @@ async function httpNetworkFetch (
location = val
}

headers.append(key, val)
// Note: Not allow pseudo-header for H2. e.g. `:status`
if (key.charCodeAt(0) !== 58) headers.append(key, val)
}
}

Expand Down