fix: ensure onConnect is always called

nodejs · Jun 14, 2024 · d2ddecc · d2ddecc
1 parent 077531a
commit d2ddecc
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/lib/core/request.js b/lib/core/request.js
@@ -25,6 +25,7 @@ const { headerNameLowerCasedRecord } = require('./constants')
 const invalidPathRegex = /[^\u0021-\u00ff]/
 
 const kHandler = Symbol('handler')
+const noop = () => {}
 
 class Request {
   constructor (origin, {
@@ -295,6 +296,14 @@ class Request {
     }
     this.aborted = true
 
+    if (!this.abort) {
+      // Make sure to always call onConnect even on errors to avoid
+      // a common user mistake of assuming that onConnect is always
+      // called before any other hook.
+      this.abort = noop
+      this[kHandler].onConnect(noop)
+    }
+
     return this[kHandler].onError(error)
   }