Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing internal module #69

Closed
polRk opened this issue Apr 25, 2023 · 2 comments · Fixed by nodejs/node#47779
Closed

Missing internal module #69

polRk opened this issue Apr 25, 2023 · 2 comments · Fixed by nodejs/node#47779

Comments

@polRk
Copy link

polRk commented Apr 25, 2023 •
edited by RaisinTen
Loading 

node:internal/bootstrap/realm:405
  if (!mod) throw new TypeError(`Missing internal module '${id}'`);
            ^

TypeError: Missing internal module 'node:path'
    at requireBuiltin (node:internal/bootstrap/realm:405:19)
    at embedderRequire (node:internal/util/embedding:44:10)
    at /app:44441:24
    at embedderRunCjs (node:internal/util/embedding:31:10)
    at node:internal/main/embedding:18:34
@polRk
Copy link
Author

polRk commented Apr 25, 2023

Bundle my app with esbuild

$ NODE_ENV=production esbuild ./src/index.ts --platform=node --define:DEV=false --format=cjs --bundle --sourcemap=inline --target=node20 --outfile=./dist/server.cjs --metafile=./dist/meta.json

RaisinTen added a commit to RaisinTen/node that referenced this issue Apr 29, 2023
@RaisinTen
sea: allow requiring core modules with the "node:" prefix
614323f 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen mentioned this issue Apr 29, 2023
Merged
@RaisinTen
Copy link
Contributor

I've sent a fix for this - nodejs/node#47779

targos pushed a commit to nodejs/node that referenced this issue May 12, 2023
@RaisinTen @targos
sea: allow requiring core modules with the "node:" prefix
1a7fc18 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2023
@RaisinTen @targos
sea: allow requiring core modules with the "node:" prefix
b8634ee 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Signed-off-by: Darshan Sen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
sea: allow requiring core modules with the "node:" prefix
befe328 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Signed-off-by: Darshan Sen <[email protected]>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
sea: allow requiring core modules with the "node:" prefix
11494df 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Signed-off-by: Darshan Sen <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this issue May 5, 2024
@RaisinTen
sea: allow requiring core modules with the "node:" prefix
003f6ba 
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs/node#47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Signed-off-by: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sea: allow requiring core modules with the "node:" prefix RaisinTen/node
2 participants
@polRk @RaisinTen