Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: official vs community and instructions for downloads page #7365

Merged
merged 15 commits into from
Jan 7, 2025
Merged

feat: official vs community and instructions for downloads page #7365

merged 15 commits into from
Jan 7, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 28, 2024

This PR, in a practical term, adds the differentiation between Official and Community installation methods and documentation for adding an Installation Method.

This is a significant guideline and content change hence, it requires approval from @nodejs/releasers @nodejs/package-maintenance @nodejs/nodejs-website

@ovflowd ovflowd requested a review from a team as a code owner December 28, 2024 14:58
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 7, 2025 3:33am

@ovflowd ovflowd requested a review from a team December 28, 2024 14:58
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 87 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
 87.6% (735/839) 74.14% (238/321) 86.58% (142/164)

Unit Test Report

Tests Skipped Failures Errors Time
182 0 💤 0 ❌ 0 🔥 6.345s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

cc @cinderblock @ImBIOS. Feel free to open new PRs following the guidelines for adding Proto and Winget as installation methods.

@ovflowd ovflowd mentioned this pull request Dec 28, 2024
Open
@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

cc @MattIPv4 and @ljharb as y'all were interested on this!

MattIPv4
MattIPv4 reviewed Dec 28, 2024
View reviewed changes
apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved
apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved
apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
mikeesto
mikeesto reviewed Dec 29, 2024
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@ovflowd ovflowd mentioned this pull request Dec 29, 2024
Merged
5 tasks
ovflowd and others added 3 commits January 6, 2025 16:13
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025
@ovflowd
Copy link
Member Author

ovflowd commented Jan 6, 2025

@ljharb another final review from your side? :D

canerakdas
canerakdas reviewed Jan 6, 2025
View reviewed changes
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
AugustinMauroy
AugustinMauroy approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

bmuenzenmeyer and others added 2 commits January 6, 2025 20:14
@bmuenzenmeyer @canerakdas
Update COLLABORATOR_GUIDE.md
ed1d959 
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @canerakdas
Update COLLABORATOR_GUIDE.md
a603c6e 
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
bmuenzenmeyer and others added 2 commits January 6, 2025 20:17
@bmuenzenmeyer @canerakdas
Update COLLABORATOR_GUIDE.md
6a27700 
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @canerakdas
Update COLLABORATOR_GUIDE.md
71b0e37 
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@ovflowd @canerakdas
Apply suggestions from code review
035e758 
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2025
@ovflowd ovflowd enabled auto-merge January 7, 2025 03:33
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2025
@ovflowd ovflowd added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit b417a64 Jan 7, 2025
16 checks passed
@ovflowd ovflowd deleted the feat/official-community-docs branch January 7, 2025 03:43
@wesleytodd wesleytodd mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeesto mikeesto mikeesto left review comments

@canerakdas canerakdas canerakdas left review comments

@mhdawson mhdawson mhdawson left review comments

@targos targos targos left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@MattIPv4 MattIPv4 MattIPv4 approved these changes

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ovflowd @ljharb @bmuenzenmeyer @targos @mhdawson @MattIPv4 @canerakdas @mikeesto @AugustinMauroy