-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup contributor and collaborator guides #657
Cleanup contributor and collaborator guides #657
Conversation
As the contents clearly states this is the collaborator guide.
Should we keep line length to 80 chars where possible? Apart from this LGTM. |
@lpinca Personally, I'm not entirely happy with this 80-chars-thingie in markdown files. It makes diffs harder to compare, when you have to hard-wrap a whole paragraph again, because you added/deleted only a couple of words. Editors can soft-wrap the content. |
No problem, Edit: Actually there isn't a consistent style, so ignore everything I wrote. |
I'm also not sure what "best practice" is in this case, but as rendered Markdown output is soft-wrapped as well and GitHub does a pretty good job with wrapping the content of diffs, I don't think we really need this 80 chars limit. |
|
||
* [Issues and Pull Requests](#issues-and-pull-requests) | ||
* [Accepting Modifications](#accepting-modifications) | ||
- [Involving the Website Admin Group](#involving-the-website-admin-group) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*
for consistency, or it this a sub-item of "Accepting Modifications"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or it this a sub-item of "Accepting Modifications"?
yep
Copied from [TSC/BasePolicies](https://github.com/nodejs/TSC/tree/master/BasePolicies) with changes related to the working group's TC, as we don't have a TC for the website.
872be6f
to
4c0e7ed
Compare
Thanks for reviewing! Replaced committer -> collaborator and some of TC -> WG. PTAL |
LGTM. |
Noticed we've got some issues with our current .md guides: