Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: web team and responsibilities #5779

Merged
merged 26 commits into from
Oct 2, 2023
Merged

meta: web team and responsibilities #5779

merged 26 commits into from
Oct 2, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 9, 2023

I'm not much versed on doing such governance documents, so any help is required.

This document is responsible on describing and "defining a set of responsibilities/bylaws) of the Node.js Web Team.

Feedback, changes and amends are super welcome!

cc @nodejs/tsc @nodejs/build @nodejs/web

@vercel
Copy link

vercel bot commented Sep 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 8:30pm

bmuenzenmeyer
bmuenzenmeyer reviewed Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my first pass.

edit:

  • can team members be members of more than one team?
  • the infra team seems like it has responsibilities outside the current site, i wonder if we should spell that out, like the download infra, digital ocean, redirects, cloudflare, etc

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
MattIPv4
MattIPv4 reviewed Sep 9, 2023
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
bmuenzenmeyer and others added 3 commits September 9, 2023 13:15
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
397eac7 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer
Update GOVERNANCE.md
e698a40 
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer
Update GOVERNANCE.md
040f878 
Signed-off-by: Brian Muenzenmeyer <[email protected]>
MattIPv4
MattIPv4 reviewed Sep 9, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more copy edit suggestions after reading through this again :)

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
d5afeed 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
bc13388 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
bmuenzenmeyer and others added 7 commits September 9, 2023 18:16
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
bd94b9c 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
a23d4ca 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
bc3ddfa 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
9edb334 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
319c4ab 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
ce54c49 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer @MattIPv4
Update GOVERNANCE.md
307cb51 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer
Copy link
Collaborator

Resolved some of the suggestions... Though the GH mobile app is odd and I might have missed some

mhdawson
mhdawson reviewed Sep 12, 2023
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
@ovflowd @MattIPv4
Update GOVERNANCE.md
41872b6 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd
Update GOVERNANCE.md
aa916b0 
Signed-off-by: Claudio W <[email protected]>
@ovflowd
Update CODEOWNERS
f6ae74c 
Signed-off-by: Claudio W <[email protected]>
@ovflowd
Update CODEOWNERS
6cf5dcc 
Signed-off-by: Claudio W <[email protected]>
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 23, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 23, 2023

cc @nodejs/web as we want to get as many approvals as possible :)

mikeesto
mikeesto reviewed Sep 24, 2023
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
@bmuenzenmeyer @mikeesto
Update GOVERNANCE.md
d4364da 
Co-authored-by: Michael Esteban <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 24, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 24, 2023
richardlau
richardlau reviewed Sep 25, 2023
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
@ovflowd ovflowd marked this pull request as draft September 25, 2023 20:29
@ovflowd
Copy link
Member Author

ovflowd commented Sep 30, 2023

Since I want to get this merged, we should remove the parts for now that conflict with Build WG and that "delegate" Infra access to the @nodejs/web-infra team. @MattIPv4 would you have some spare time for updating this PR with such amendments?

Ty!

MattIPv4
MattIPv4 reviewed Oct 1, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovflowd thoughts on this for clarity?

GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
@ovflowd @MattIPv4
Apply suggestions from code review
b2ff3f6 
Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd marked this pull request as ready for review October 1, 2023 20:29
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 1, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 1, 2023
@ovflowd ovflowd added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 4dcc61f Oct 2, 2023
@ovflowd ovflowd deleted the meta/governance-web-team branch October 2, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

@mhdawson mhdawson mhdawson left review comments

@richardlau richardlau richardlau left review comments

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@shanpriyan shanpriyan shanpriyan approved these changes

@mikeesto mikeesto mikeesto approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ovflowd @bmuenzenmeyer @richardlau @mhdawson @MattIPv4 @aymen94 @mikeesto @shanpriyan