-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused layouts and their CSS. #2624
Remove unused layouts and their CSS. #2624
Conversation
Actually now that I see site.json it seems the feed is also unused. Let me know how to proceed. nodejs.org/locale/en/site.json Lines 19 to 32 in ceaa1c0
|
@Trott should I also remove completely announcements? |
I'm not sure. I don't know the ramifications. We can ping more widely for review or I can be educated. |
Let's ask more people. I added the complete removal of announcements. Not sure if we should add any redirections or not. |
@nodejs/website |
@nodejs/build should we redirect the announcements index file or their feed? Note that this actually only removes the Otherwise, I will split this patch so that we can merge the first one which is safe. |
Since I'm not getting any reviews, I dropped the second patch from this PR. Now the patch just removes unused layouts and their CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me.
I'm a little shocked that we have nobody showing up to review though? what happened to our website team and where is our shiny new website that we've had a whole team pouring over?
* announcements.hbs * in-the-news.hbs
I think we haven't somebody who can give an answer about removed layouts, so let's merge PR and take a look on any issues that can be produced |
This shouldn't affect anything. I moved the other patch to separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about removing the content (now in other PR), but these do look unreferenced anyway so 👍
@rvagg you can find that work in nodejs/nodejs.dev. |
@bnb thanks, so when do we get to replace nodejs.org? |
That's a great question. I'm not involved to the point to be able to assert an answer to it. Perhaps @amiller-gh could give some insight on, though I don't necessarily think this PR is the correct venue for that. |
I left the
blogAnnounce
collection as is, although it probably is redundant too, so must be its feed