Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Prism CSS files. #2461

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Remove unused Prism CSS files. #2461

merged 1 commit into from
Sep 18, 2019

Conversation

XhmikosR
Copy link
Contributor

These aren't used, probably left for historical reasons?

@XhmikosR XhmikosR mentioned this pull request Aug 25, 2019
Merged
@XhmikosR XhmikosR mentioned this pull request Sep 8, 2019
Merged
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 10, 2019 •
edited
Loading

Can we get this and some of the other CSS PRs moving?

https://github.com/nodejs/nodejs.org/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+author%3AXhmikosR+css

and

https://github.com/nodejs/nodejs.org/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+author%3AXhmikosR+stylus

I'd like to clean up the CSS and finish with the Sass move.

@XhmikosR
Copy link
Contributor Author

Ping

Trott
Trott approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wouldn't mind a few more sets of eyes to make sure I'm not missing anything. @nodejs/website

bnb
bnb approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Served the site locally, everything seemed to work to me. Relatively trivial revert if something is actually broken. :shipit:

@aymen94 aymen94 merged commit 5f63b2c into nodejs:master Sep 18, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-unused-prism-css branch September 19, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabapalfi csabapalfi csabapalfi approved these changes

@bnb bnb bnb approved these changes

@Trott Trott Trott approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XhmikosR @csabapalfi @bnb @Trott @aymen94