make Korean docs up-to-date #1032

outsideris · 2016-11-28T05:26:34Z

follow changed in English and #1022

outsideris · 2016-11-28T05:26:48Z

@nodejs/nodejs-ko

yous · 2016-11-28T05:29:19Z

locale/ko/about/working-groups.md

-The website working group's purpose is to build and maintain a public
-website for the `Node.js` project.
+The Website Working Group's purpose is to build and maintain a public
+website for the Node.js project.


This change (`Node.js` → Node.js) is not applied to the translation.

yous · 2016-11-28T05:30:27Z

locale/ko/about/working-groups.md

-* Foster and enable a community of translators.
+Responsibilities include:
+* Developing and maintaining a build and automation system for nodejs.org.
+* Ensuring the site is regularly updated with changes made to Node.js, like


Also please change `nodejs.org` to nodejs.org, `Node.js` to Node.js in translation.

yous · 2016-11-28T05:32:10Z

locale/ko/about/working-groups.md

 * Node.js 이슈 트래커에서 스트림 관련 이슈를 처리합니다.
 * Node.js 프로젝트 내 스트림 문서를 작성하고 수정합니다.
 * Node.js 프로젝트 내 스트림 하위 클래스의 변경사항을 리뷰합니다.
 * 스트림 변경사항을 Node.js 프로젝트에서 이 프로젝트로 리다이렉트합니다.
 * Node.js 내 스트림 프로바이더의 구현체를 지원합니다.
-* 읽기 가능한 스트림의 버전이 Node.js에 포함되도록 권장합니다.
+* `읽기 가능한 스트림`의 버전이 Node.js에 포함되도록 권장합니다.


Use 'readable-stream' as is instead of '읽기 가능한 스트림', as it's a package name.

yous · 2016-11-28T05:33:42Z

locale/ko/about/working-groups.md


-트레이싱 워킹 그룹의 목적은 Node.js로 작성된 소프트웨어의 투명성을 증가시키는 것입니다.
+Diagnostics 워킹 그룹의 목적은 Node.js 도구와 JavaScript VM에서 사용할 수 있는
+광범위하고 확장성 진단 인터페이스를 만들고 문서화하는 것입니다.


How about '광범위한'?

yous · 2016-11-28T05:34:41Z

locale/ko/about/working-groups.md

-* 추적 및 디버깅 생태계를 육성합니다.
+* `v8_inspector`를 Node.js에 통합하도록 V8과 협업합니다.
+* `trace_event`를 Node.js에 통합하도록 V8과 협업합니다.
+* `async_wrap`과 `async_hooks`을 개량할 수 있도록 Core 팀과 협업합니다.


Maybe '`async_hooks`를' here.

yous · 2016-11-28T05:43:42Z

locale/ko/about/working-groups.md

@@ -633,8 +610,7 @@ Its responsibilities are:
 The Node.js Testing Working Group's purpose is to extend and improve testing of
 the Node.js source code.

-It's responsibilities are:
-


Remove this empty line in translation.

yous · 2016-11-28T05:44:45Z

locale/ko/download/package-manager.md

@@ -251,15 +251,17 @@ Run as root on RHEL, CentOS or Fedora, for Node.js v4 LTS Argon:
 CentOS 5)의 Node.js 패키지도 사용할 수 있습니다. 설치되어 있지 않다면 설정 스크립트가 확인하고
 안내할 것입니다.

+Node.js v6 LTS를 설치하려면 RHEL, CentOS or Fedora에서 root로 실행하세요.


RHEL, CentOS or Fedora → RHEL, CentOS, Fedora

yous · 2016-11-28T05:45:03Z

locale/ko/download/package-manager.md

 <!--
 ```bash
-curl --silent --location https://rpm.nodesource.com/setup_4.x | bash -
+curl --silent --location https://rpm.nodesource.com/setup_6.x | bash -


Not applied in translation.

yous · 2016-11-28T05:45:20Z

locale/ko/download/package-manager.md

 ```

-Alternatively for Node.js v6:
+Alternatively for Node.js v7:


Not applied in translation.

yous · 2016-11-28T05:45:26Z

locale/ko/download/package-manager.md


 ```bash
-curl --silent --location https://rpm.nodesource.com/setup_6.x | bash -
+curl --silent --location https://rpm.nodesource.com/setup_7.x | bash -


Not applied in translation.

outsideris · 2016-11-28T07:15:34Z

I updated as feedback. Thank you.

outsideris · 2016-12-09T05:46:10Z

I rebased it on master to fix the build failure.

fhemberger · 2017-02-04T06:12:01Z

@outsideris Hi, could you please rebase it again and fix the conflict? Then I'd be happy to merge it.

outsideris · 2017-02-04T12:42:53Z

@fhemberger Sorry, I forgot it. I will address it.

sotayamashita · 2017-02-04T13:17:20Z

@outsideris I think you should follow the commit message in TRANSLATION.md

For example:

nodejs-ko: up-to-date

outsideris · 2017-02-04T13:21:53Z

@sotayamashita Oops! I didn't know the rule. I will fix commit messages in this PR.

outsideris · 2017-02-08T03:54:06Z

@fhemberger @sotayamashita I rebased it and fixed the commit message.

@nodejs/nodejs-ko Please review this. I made this pull request about 2 months ago. In this time, I just rebase it onto latest matser branch.

yous · 2017-02-08T06:58:47Z

locale/ko/about/working-groups.md

+* 모든 기능과 표준 준수 (표준: ECMA, 유니코드...)
+* 트래커에 올라온 세계화(Globalization)와 국제화(Internationalization) 이슈를 지원합니다.
+* 가이드라인과 권장 사례를 만듭니다.
+* 기존의 `Intl` 구현체를 정체합니다.


Did you mean '정제합니다'?

yous · 2017-02-08T07:01:25Z

locale/ko/docs/guides/nodejs-docker-webapp.md

+-->
+
+## .dockerignore 파일
+`Dockerfile`과 같은 디렉터리에 `.dockerignore` 파일을 다음 내용을 만드세요.


Please insert a new line above this line.

다음 내용을 → 다음 내용으로

outsideris · 2017-02-09T03:47:26Z

I updated it. @yous Thank you for review.

fhemberger · 2017-02-09T06:29:50Z

Thank you!

yous reviewed Nov 28, 2016

View reviewed changes

outsideris force-pushed the update-korean-1127 branch from bc4924c to dea3ed0 Compare November 28, 2016 07:14

outsideris force-pushed the update-korean-1127 branch from dea3ed0 to be97d49 Compare December 9, 2016 05:45

sotayamashita added merge conflict labels Feb 4, 2017

outsideris force-pushed the update-korean-1127 branch from be97d49 to 21236c7 Compare February 8, 2017 03:49

outsideris removed the merge conflict label Feb 8, 2017

fhemberger removed the needs WG +1 label Feb 8, 2017

marocchino self-requested a review February 8, 2017 06:21

marocchino approved these changes Feb 8, 2017

View reviewed changes

yous reviewed Feb 8, 2017

View reviewed changes

nodejs-ko: Update files - all files

e5f8fb3

outsideris force-pushed the update-korean-1127 branch from 21236c7 to e5f8fb3 Compare February 9, 2017 03:46

yous approved these changes Feb 9, 2017

View reviewed changes

fhemberger merged commit 87233c0 into nodejs:master Feb 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make Korean docs up-to-date #1032

make Korean docs up-to-date #1032

outsideris commented Nov 28, 2016

outsideris commented Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

yous Nov 28, 2016

outsideris commented Nov 28, 2016

outsideris commented Dec 9, 2016

fhemberger commented Feb 4, 2017

outsideris commented Feb 4, 2017

sotayamashita commented Feb 4, 2017 •

edited

Loading

outsideris commented Feb 4, 2017

outsideris commented Feb 8, 2017

yous Feb 8, 2017

yous Feb 8, 2017

outsideris commented Feb 9, 2017

fhemberger commented Feb 9, 2017

make Korean docs up-to-date #1032

make Korean docs up-to-date #1032

Conversation

outsideris commented Nov 28, 2016

outsideris commented Nov 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

outsideris commented Nov 28, 2016

outsideris commented Dec 9, 2016

fhemberger commented Feb 4, 2017

outsideris commented Feb 4, 2017

sotayamashita commented Feb 4, 2017 • edited Loading

outsideris commented Feb 4, 2017

outsideris commented Feb 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

outsideris commented Feb 9, 2017

fhemberger commented Feb 9, 2017

sotayamashita commented Feb 4, 2017 •

edited

Loading