release post script breaking without ### Notable Changes

[MylesBorins]

If a release post does not include### Notable Changes the tool blows up

[lpinca]

I think it makes sense to always include a ### Notable Changes section even if it is a security only release. For example this is what @rvagg did with 0.12.15 and 0.10.46:

• https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V012.md#2016-06-23-version-01215-maintenance-rvagg
• https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V010.md#2016-06-23-version-01046-maintenance-rvagg

[phillipj]

IMO the release script should never stand in the way of getting a release post out the door asap. Ideally it would be forgiving and try to do as best as it can, and maybe print a warning or two if something is missing. Of course it simplifies the release post script if could be confident the changelog is formatted correctly, but that would imply linting the changelog somehow before it's merged into core.

[lpinca]

The changelog should definitely be linted before being commited.
I agree that the release script should be forgiving but to a certain degree. If an important section is missing, for example, it should throw an error, like it does now.

[lpinca]

Ref: nodejs/node#7394.

[lpinca]

It was like this (no Notable Changes -> error) even before the script had been updated to handle the new changelog structure.
I still think that this is the correct behavior but I'm fine with changing it to handle cases where "Notable Changes" is missing.

[fhemberger]

@thealphanerd @lpinca Does this issue still exist?

[MylesBorins]

it does AFAIK

…

On Fri, Dec 16, 2016, 6:13 PM Frederic Hemberger ***@***.***> wrote: @thealphanerd <https://github.com/TheAlphaNerd> @lpinca <https://github.com/lpinca> Does this issue still exist? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#802 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV1iZo53y8qVP_eTZ5QfStzH1h9dEks5rIxswgaJpZM4I9Vor> .

[lpinca]

Yeah but the tool was designed to do this.
I mean it errors if there isn't a "### Notable Changes" section. It was like this from the beginning.