-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use consistent typography for Note:
#6987
Conversation
Typography choices for `Note:` text is all over the map in stream.md. This change introduces the following consistently for `Note:` text: * Only `Note:` is in bold. * Additional emphasis is done with _italics_, not CAPITALIZATION. * The first word after `Note:` is capitalized. * When classes are mentioned, they are enclosed in backticks. * Only one space is used between sentences.
LGTM |
@@ -924,8 +924,8 @@ becomes available. There is no need, for example to "wait" until | |||
Buffer encoding, such as `'utf8'` or `'ascii'` | |||
* return {Boolean} Whether or not more pushes should be performed | |||
|
|||
Note: **This method should be called by Readable implementors, NOT | |||
by consumers of Readable streams.** | |||
**Note:** This method should be called by Readable implementors, _not_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readable
should be backticked, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bengl Yup, it sure should. I'll update the PR.
Is there (could there be (should there be)) a tracking issue for cleaning this up in the rest of the docs? |
I am working on normalizing the various |
oh... also, can we fold these edits up into the existing #6947? |
@jasnell: I'm reading your first comment as indicating that I should change these to As for #6947, I'm not sure what you mean by
Or did you mean something else? I'm also fine with just leaving this open until #6947 lands and then inspecting the results to see if this PR should be rebased and modified to deal with any stray notes that were missed. |
Sure, feel free to open such an issue. :-P |
LGTM |
Checklist
Affected core subsystem(s)
doc
Description of change
Typography choices for
Note:
text is all over the map in stream.md.This change introduces the following consistently for
Note:
text:Note:
is in bold.Note:
is capitalized./cc @nodejs/documentation