Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: multiple cas works in any order #6606

Closed
wants to merge 1 commit into from
Closed

test: multiple cas works in any order #6606

wants to merge 1 commit into from

Conversation

suryagh
Copy link
Contributor

@suryagh suryagh commented May 5, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

if the valid ca is the first item within the concatenated string
then the bug addressed by #4099 was not getting exposed. This test
makes sure the order of valid ca should not effect the expected
behaviour when multiple ca certs are concatenated.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 5, 2016
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label May 5, 2016
bnoordhuis
bnoordhuis reviewed May 6, 2016
View reviewed changes
test/parallel/test-tls-two-cas-one-string.js
const key =
fs.readFileSync(`${common.fixturesDir}/keys/agent3-key.pem`, 'utf8');
fs.readFileSync(`${common.fixturesDir}/keys/agent3-key.pem`, 'utf8');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo the whitespace changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@suryagh
test: multiple cas works in any order
13fdf42 
if the valid `ca` is the first item within the concatinated string
then the bug addressed by nodejs#4099 was not getting exposed. This test
makes sure the order of valid `ca` should not effect the expected
behavior when multiple `ca` certs are concatinated.
@suryagh suryagh closed this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suryagh @bnoordhuis @jasnell @mscdex @nodejs-github-bot