Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update last name for jkrems #57006

Merged
merged 1 commit into from
Feb 13, 2025
Merged

meta: update last name for jkrems #57006

merged 1 commit into from
Feb 13, 2025

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented Feb 11, 2025

Also adds current work email to mailmap.

Caught this in the latest release proposal (#57005).

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Feb 11, 2025
@jkrems
meta: update last name for jkrems
de15d6c 
Also adds current work email to mailmap.

PR-URL: nodejs#57006
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 11, 2025
@jkrems jkrems added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65184/

@aduh95
Copy link
Contributor

aduh95 commented Feb 13, 2025

@jkrems added the request-ci Add this label to start a Jenkins CI on a PR. label

FWIW this kind of changes do not require Jenkins CI run

@aduh95 aduh95 merged commit 128ec44 into nodejs:main Feb 13, 2025
52 of 55 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Feb 13, 2025

Landed in 128ec44

@jkrems jkrems deleted the mv-krems-martin branch February 13, 2025 16:47
targos pushed a commit that referenced this pull request Feb 17, 2025
@jkrems @targos
meta: update last name for jkrems
2ec4ff1 
Also adds current work email to mailmap.

PR-URL: #57006
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@jkrems @acidiney
meta: update last name for jkrems
0271132 
Also adds current work email to mailmap.

PR-URL: nodejs#57006
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@Flarna Flarna Flarna approved these changes

@jazelly jazelly jazelly approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jkrems @nodejs-github-bot @aduh95 @ljharb @lpinca @anonrig @Flarna @jazelly