src: improve error handling in node_url #56886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Feb 3, 2025
Eliminate uses of USE and ToLocalChecked to properly propagate errors
jasnell
force-pushed
the
jasnell/url-errorhandling
branch
from
6098c10 to
a38dcfd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Feb 3, 2025
jasnell
added
the
author ready
jasnell
added
the
commit-queue
legendecas
approved these changes
Feb 4, 2025
addaleax
approved these changes
Feb 4, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 95c04e2 |
targos
pushed a commit
that referenced
this pull request
Feb 5, 2025
Eliminate uses of USE and ToLocalChecked to properly propagate errors PR-URL: #56886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate uses of USE and ToLocalChecked to properly propagate errors.
Also clean up
v8::prefix uses and switch to usingToV8Value(...)where appropriate