src,deps: port some electron boringssl workarounds #56812
Closed
+110
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
targos
changed the title
codebytere
approved these changes
Jan 29, 2025
jasnell
changed the title
Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
jasnell/ncrypto-bssl-electron
branch
from
d5c54ff to
1b53fec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
anonrig
approved these changes
Feb 3, 2025
jasnell
added a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: James M Snell <[email protected]> PR-URL: #56812 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in 206ebeb |
targos
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: James M Snell <[email protected]> PR-URL: #56812 Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #56792 which accounts for the first six commits. This draft PR adds only the last commit.
This starts to port the boringssl fixups from electron https://github.com/electron/electron/blob/main/patches/node/fix_handle_boringssl_and_openssl_incompatibilities.patch#L93 /cc @codebytere
This PR will be updated and moved to ready once #56792 lands.