test: mark test-esm-loader-hooks-inspect-wait flaky
#56803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test-esm-loader-hooks-inspect-wait` is occasionally crashing on more platforms than Linux. Mark the test as flaky on those platforms as well.
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jan 28, 2025
lpinca
approved these changes
Jan 28, 2025
richardlau
added
the
author ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56803 +/- ##
=======================================
Coverage 89.22% 89.22%
=======================================
Files 663 663
Lines 191974 191974
Branches 36926 36920 -6
=======================================
+ Hits 171286 171290 +4
+ Misses 13561 13559 -2
+ Partials 7127 7125 -2 |
jasnell
approved these changes
Jan 28, 2025
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
|
Not seeing much reason to make this wait the 48 hours to land... added the fast-track label. |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in adf8e97 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
`test-esm-loader-hooks-inspect-wait` is occasionally crashing on more platforms than Linux. Mark the test as flaky on those platforms as well. PR-URL: #56803 Refs: #54346 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-esm-loader-hooks-inspect-waitis occasionally crashing on more platforms than Linux. Mark the test as flaky on those platforms as well.Refs: #54346