-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: be more generational GC friendly #56767
Open
ywave620
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
ywave620:gc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid any potential ref to Buffer in new generation from old generation
Review requested:
|
nodejs-github-bot
added
http
Issues or PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jan 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56767 +/- ##
==========================================
- Coverage 89.22% 89.21% -0.01%
==========================================
Files 662 663 +1
Lines 192125 191976 -149
Branches 36972 36924 -48
==========================================
- Hits 171421 171273 -148
- Misses 13543 13566 +23
+ Partials 7161 7137 -24
|
tests are failing |
Failed tests should be fixed by #56768. But the linter complaints shall be addressed. |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 27, 2025
@legendecas CI is green, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid any potential ref to Buffer in new generation from old generation. Otherwise, the lightweight Minor GC could not collect Buffer, as a result, the heavy Major GC may be invoked more frequently
Similar tricks are used in Writable and Readable
node/lib/internal/streams/writable.js
Line 779 in ce6a628
node/lib/internal/streams/readable.js
Line 1598 in ce6a628