Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update nghttp3 to 1.7.0 #56333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp3 to 1.7.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Dec 22, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Dec 22, 2024
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp3 branch from 078d02b to 3b458da Compare January 26, 2025 00:31
@RafaelGSS
Copy link
Member

Wait, it seems this version requires patching as some symbols aren't being linked correctly.

@targos
Copy link
Member

targos commented Jan 29, 2025

2025-01-26T01:34:15.7687105Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_http_parse_priority':
2025-01-26T01:34:15.7690793Z nghttp3_http.c:(.text+0x3c): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:15.7692931Z /usr/bin/ld: nghttp3_http.c:(.text+0x5a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:15.7703124Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_pri_parse_priority_versioned':
2025-01-26T01:34:15.7704513Z nghttp3_http.c:(.text+0x132): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:15.7705318Z /usr/bin/ld: nghttp3_http.c:(.text+0x14a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.3763265Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_http_parse_priority':
2025-01-26T01:34:16.3764773Z nghttp3_http.c:(.text+0x3c): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:16.3765654Z /usr/bin/ld: nghttp3_http.c:(.text+0x5a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.3767172Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_pri_parse_priority_versioned':
2025-01-26T01:34:16.3768646Z nghttp3_http.c:(.text+0x132): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:16.3769472Z /usr/bin/ld: nghttp3_http.c:(.text+0x14a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.8948937Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)
2025-01-26T01:34:16.8992169Z make[2]: *** [cctest.target.mk:354: /home/runner/work/node/node/node/out/Release/cctest] Error 1
2025-01-26T01:34:16.8993696Z make[2]: *** Waiting for unfinished jobs....
2025-01-26T01:34:17.1519596Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)
2025-01-26T01:34:17.1555014Z make[2]: *** [embedtest.target.mk:312: /home/runner/work/node/node/node/out/Release/embedtest] Error 1
2025-01-26T01:34:18.0096596Z rm 8c172c245075c22cfbd0b4982ce5452e8c890687.intermediate d567cc7bfa368e8372691deb815cb082aa225f95.intermediate c9ad195c230c21da8c09325739d93789c150ea07.intermediate 8818a687bcd71f4d195e33ad9a6b5cf087ba2923.intermediate
2025-01-26T01:34:18.0105437Z make[1]: *** [Makefile:135: node] Error 2

sfparse is explicitly excluded here:

# sfparse is also used by nghttp2 and is included by nghttp2.gyp
# 'nghttp3/lib/sfparse.c'

@jasnell
Copy link
Member

jasnell commented Jan 29, 2025

Leave this one please. I'll be doing another round of quic/http3 updates next month and will update the dependencies at that time.

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Jan 29, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp3 branch from 3b458da to 579e7de Compare February 2, 2025 00:33
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp3 branch from 579e7de to 3deb02f Compare February 9, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants