Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update simdjson to 3.11.6 #56250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 13, 2024

This is an automated update of simdjson to 3.11.6.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Dec 13, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 13, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@anonrig
Copy link
Member

anonrig commented Dec 13, 2024

cc @nodejs/build blocked due to macOS infrastructure

@anonrig anonrig added the blocked PRs that are blocked by other issues or PRs. label Dec 14, 2024
@lemire
Copy link
Member

lemire commented Jan 6, 2025

@anonrig Strange. This should build with LLVM 12:

https://godbolt.org/z/aK7W667WT

Let me see if I can't add some checks.

@lemire
Copy link
Member

lemire commented Jan 6, 2025

It turns out that Apple LLVM lies about supporting concepts. Prior to Apple LLVM 14, it is only partially supported... and so, some functionality is missing, hence the breaks. Thankfully, it should be easy enough to fix it.

@lemire
Copy link
Member

lemire commented Jan 7, 2025

Version 3.11.4 should solve the issue. https://github.com/simdjson/simdjson/releases/tag/v3.11.4

@nodejs-github-bot nodejs-github-bot changed the title deps: update simdjson to 3.11.3 deps: update simdjson to 3.11.5 Jan 12, 2025
@nodejs-github-bot nodejs-github-bot changed the title deps: update simdjson to 3.11.5 deps: update simdjson to 3.11.6 Jan 19, 2025
@lemire
Copy link
Member

lemire commented Jan 20, 2025

Please see PR #56663

I believe that something is wrong with the automated updates.

@aduh95 aduh95 force-pushed the actions/tools-update-simdjson branch from 5641f59 to 9aa8893 Compare January 28, 2025 22:09
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Jan 28, 2025
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants