[v20.x backport] esm: mark import attributes and JSON module as stable #55961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
JakobJingleheimer
approved these changes
Nov 23, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
marco-ippolito
approved these changes
Jan 3, 2025
|
the 2 v8 commits dont have a PR-URL 🤔 I can amend them, should I set this PR as their PR URL? |
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
983a7d4 to
bc445a0
Compare
|
@nodejs/releasers not sure what to do about these commits 
|
Yes, set the PR-URL for those commits to this PR. Also add reviewers (yourself and Jacob). |
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
PR-URL: nodejs#55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: nodejs#55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: nodejs#55961
PR-URL: nodejs#55855 Refs: nodejs#55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Backport-PR-URL: nodejs#55961
aduh95
force-pushed
the
warning-for-import-assertions-20
branch
from
e44f6d8 to
f0fd177
Compare
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 22, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55961
Backport-PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 22, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
PR-URL: #55961
Backport-PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 22, 2025
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 22, 2025
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Backport-PR-URL: #55961
|
Landed in 5bf61c5...595e71b |
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 23, 2025
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 24, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for removal in 12.6
See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ
Bug: v8:10958
Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
Auto-Submit: Shu-yu Guo <[email protected]>
Commit-Queue: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92044}
Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 24, 2025
Original commit message:
[import-attributes] Deprecate 'assert' for dynamic import as well
Bug: v8:10958
Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#92123}
Refs: v8/v8@26fd1df
PR-URL: #55961
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 24, 2025
The two proposals reached stage 4 at the October 2024 meeting. PR-URL: #55333 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #55961
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 24, 2025
PR-URL: #55855 Refs: #55333 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Backport-PR-URL: #55961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.