readline: fix unresolved promise on abortion #54030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Can someone merge this? |
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jan 26, 2025
|
@jasnell what do I still need to do to get this merged? |
|
looks like the PR needs to be rebased on main in order to clear up the CI failures. Please be sure to rebase and not merge. |
DanielVenable
force-pushed
the
readline-reject-promise-on-abortion
branch
from
5eaf6b4 to
30387cf
Compare
anonrig
approved these changes
Jan 29, 2025
jasnell
added
the
commit-queue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54030 +/- ##
==========================================
- Coverage 89.21% 89.21% -0.01%
==========================================
Files 663 663
Lines 192002 192012 +10
Branches 36932 36926 -6
==========================================
+ Hits 171291 171295 +4
Misses 13574 13574
- Partials 7137 7143 +6
|
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54030 ✔ Done loading data for nodejs/node/pull/54030 ----------------------------------- PR info ------------------------------------ Title readline: fix unresolved promise on abortion (#54030) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch DanielVenable:readline-reject-promise-on-abortion -> nodejs:main Labels readline, needs-ci Commits 3 - readline: fix unresolved promise on abortion - readline: fix js-lint errors - readline: fix test so it tests aborting a question with both ctrl+C a… Committers 1 - Daniel Venable <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54030 Fixes: https://github.com/nodejs/node/issues/53497 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54030 Fixes: https://github.com/nodejs/node/issues/53497 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 25 Jul 2024 02:02:05 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54030#pullrequestreview-2574292629 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54030#pullrequestreview-2582544569 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-01-29T22:29:25Z: https://ci.nodejs.org/job/node-test-pull-request/64833/ - Querying data for job/node-test-pull-request/64833/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13043107844 |
jasnell
pushed a commit
that referenced
this pull request
Jan 30, 2025
Fixes: #53497 PR-URL: #54030 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in 5557ce4 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
Fixes: #53497 PR-URL: #54030 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53497