esm: fix support for URL instances in register
#49655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
GeoffreyBooth
approved these changes
Sep 14, 2023
GeoffreyBooth
added
author ready
github-actions
bot
removed
the
request-ci
GeoffreyBooth
added
the
fast-track
|
Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49655 ✔ Done loading data for nodejs/node/pull/49655 ----------------------------------- PR info ------------------------------------ Title esm: fix support for `URL` instances in `register` (#49655) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:register-url -> nodejs:main Labels esm, fast-track, author ready, needs-ci, commit-queue-squash Commits 2 - esm: fix support for `URL` instances in `register` - update docs Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/49655 Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49655 Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 14 Sep 2023 19:44:19 GMT ✔ Approvals: 1 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49655#pullrequestreview-1627697632 ℹ This PR is being fast-tracked ✘ This PR needs to wait 164 more hours to land (or 44 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-14T21:43:17Z: https://ci.nodejs.org/job/node-test-pull-request/53955/ - Querying data for job/node-test-pull-request/53955/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6191726611 |
GeoffreyBooth
removed
the
commit-queue-failed
anonrig
approved these changes
Sep 15, 2023
anonrig
approved these changes
Sep 15, 2023
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
GeoffreyBooth
approved these changes
Sep 16, 2023
jasnell
approved these changes
Sep 16, 2023
GeoffreyBooth
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 56ecf29 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49655 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49655 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
PR-URL: nodejs#49655 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #49655 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49655 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49655 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #49633 (comment)