[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

rluvaton · 2023-08-14T19:46:53Z

Backport: #48787

nodejs-github-bot · 2023-08-14T19:46:57Z

Review requested:

@nodejs/test_runner

Backport-PR-URL: nodejs#49174 PR-URL: nodejs#48787 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#48787 Backport-PR-URL: nodejs#49174 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

rluvaton · 2023-08-15T09:35:00Z

test/parallel/test-runner-cli.js

-  assert.match(stdout, /ok 2 - this should pass/);
-  assert.match(stdout, /not ok 3 - this should fail/);
-  assert.match(stdout, /ok 4 - .+subdir.+subdir_test\.js/);
-  assert.match(stdout, /ok 5 - this should pass/);


Removed this, as this is like that on main and was like that at the time of the original PR.

how was it added anyway?

nodejs-github-bot · 2023-08-15T12:36:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53335/

nodejs-github-bot · 2023-08-15T16:57:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53349/

PR-URL: nodejs#48877 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48876 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Co-authored-by: Luigi Pinca <[email protected]> PR-URL: nodejs#48611 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: nodejs#48888 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: nodejs#48860 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#48892 Fixes: nodejs#48887 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#48896 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

PR-URL: nodejs#48898 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>

Refs: nodejs/single-executable#73 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#48191 Fixes: nodejs/single-executable#73 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: nodejs#48828 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Fixes: nodejs#48894 PR-URL: nodejs#48903 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: nodejs#48907 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

PR-URL: nodejs#46662 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

PR-URL: nodejs#49069 Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

This commit adds the delimiters ^ and $ to the regex that matches the MIME types for `data:` URLs. PR-URL: nodejs#49104 Fixes: nodejs#48957 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

PR-URL: nodejs#49114 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

- Build a static table of octal strings and use it instead of building octal strings repeatedly during printing. - Print a newline and an offset for every 64 bytes in the case of printing array literals so it's easier to locate variation in snapshot blobs. - Rework the printing routines so that the differences are only made in a WriteByteVectorLiteral routine. We can update this for compression support in the future. - Rename Snapshot::Generate() that write the data as C++ source instead of a blob as Snaphost::GenerateAsSource() for clarity, and move the file stream operations into it to streamline error handling. PR-URL: nodejs#48851 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

This commit reverts the revert in bb52656. It also includes the fix for the issue that required the revert (nodejs#49059 (comment)) and an additional common.mustCall() in the added test. Refs: nodejs#49059 Refs: nodejs#49110 PR-URL: nodejs#49116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#49119 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

PR-URL: nodejs#49033 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

Replace `type` with `Type: {Promise}`. Plus, fix incorrect verb(`creates` -> `returns`) in description. PR-URL: nodejs#49121 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#49124 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: nodejs#49034 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

PR-URL: nodejs#49129 Refs: nodejs#49120 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

- Always check stderr before stdout as the former would contain error information. - Always match the full stdout to avoid surprises. - Use `deepStrictEqual` when appropriate to get more informative test failures. - Remove leading slashes from relative paths/URLs to not confuse them with absolute paths. - Remove unnecessary `--no-warnings` flag. PR-URL: nodejs#49131 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

PR-URL: nodejs#49146 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

- @rollup/[email protected] - [email protected] PR-URL: nodejs#49122 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

PR-URL: nodejs#49125 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

PR-URL: nodejs#49126 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Subsystems: blob, child_process, common, crypto, http, http2, readline, repl, snapshot, trace_events PR-URL: nodejs#49127 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>

PR-URL: nodejs#49128 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#49143 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#48787 Backport-PR-URL: nodejs#49174 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Aug 14, 2023

rluvaton mentioned this pull request Aug 14, 2023

test: relocate test files fixtures for better understanding #48787

Merged

rluvaton force-pushed the backport-48787-to-v20.x branch from 8b98c18 to 6514d06 Compare August 14, 2023 20:15

MoLow approved these changes Aug 14, 2023

View reviewed changes

rluvaton force-pushed the backport-48787-to-v20.x branch from 6514d06 to 2dca814 Compare August 15, 2023 09:33

rluvaton commented Aug 15, 2023

View reviewed changes

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2023

rluvaton and others added 15 commits August 15, 2023 14:34

test_runner: fix global before not called when no global test exists

3b5663c

PR-URL: nodejs#48877 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

doc: add ver of 18.x where Node-api 9 is supported

0fce9d0

Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48876 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

tools: update lint-md-dependencies to [email protected]

23aa191

PR-URL: nodejs#48888 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rich Trott <[email protected]>

doc: improve requireHostHeader

eb7fa4b

PR-URL: nodejs#48860 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

deps: update ada to 2.6.0

af900c9

PR-URL: nodejs#48896 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>

fs: make mkdtemp accept buffers and URL

f8b421e

PR-URL: nodejs#48828 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

fs: mention URL in NUL character error message

d2e92b9

PR-URL: nodejs#48828 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

doc: add new reporter events to custom reporter examples

5268181

Fixes: nodejs#48894 PR-URL: nodejs#48903 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

src: remove ContextEmbedderIndex::kBindingDataStoreIndex

3066f69

We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>

src,permission: restrict by default when pm enabled

833e571

PR-URL: nodejs#48907 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

module: ensure successful import returns the same result

223e86a

PR-URL: nodejs#46662 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

aduh95 and others added 22 commits August 15, 2023 15:47

esm: fix globalPreload warning

8179751

PR-URL: nodejs#49069 Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

lib: fix MIME overmatch in data URLs

c1f7728

This commit adds the delimiters ^ and $ to the regex that matches the MIME types for `data:` URLs. PR-URL: nodejs#49104 Fixes: nodejs#48957 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

doc: make the NODE_VERSION_IS_RELEASE revert clear

00de8be

PR-URL: nodejs#49114 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

doc: fix name of the flag in initialize() docs

d7f5f25

PR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

src: remove duplicated code in GenerateSingleExecutableBlob()

eba3a40

PR-URL: nodejs#49119 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

deps: update zlib to 1.2.13.1-motley-526382e

6206ccd

PR-URL: nodejs#49033 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

doc: fix Type notation in webstreams

0b2e81c

Replace `type` with `Type: {Promise}`. Plus, fix incorrect verb(`creates` -> `returns`) in description. PR-URL: nodejs#49121 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

tools: update eslint to 8.47.0

44a3626

PR-URL: nodejs#49124 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

deps: update googletest to 7e33b6a

ef9f868

PR-URL: nodejs#49034 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>

tools: add @reporters/github to tools

f43e5e1

PR-URL: nodejs#49129 Refs: nodejs#49120 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

tools: use @reporters/github when running in github actions

9b8f69e

PR-URL: nodejs#49129 Refs: nodejs#49120 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

tools: use spec reporter in actions

350d3d3

PR-URL: nodejs#49129 Refs: nodejs#49120 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

test: fix assertion message in test_async.c

4929204

PR-URL: nodejs#49146 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

tools: update lint-md-dependencies

0b79e8f

- @rollup/[email protected] - [email protected] PR-URL: nodejs#49122 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

test: use tmpdir.resolve() in fs tests

f8026e0

PR-URL: nodejs#49125 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

test: use tmpdir.resolve() in fs tests

1554f51

PR-URL: nodejs#49126 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

test: use tmpdir.resolve()

58512eb

Subsystems: blob, child_process, common, crypto, http, http2, readline, repl, snapshot, trace_events PR-URL: nodejs#49127 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>

test: use tmpdir.resolve()

4a24ffc

PR-URL: nodejs#49128 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

doc: add print results for examples in WebStreams

2ed105a

PR-URL: nodejs#49143 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

rluvaton mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

test: reorder test files fixtures for better understanding

7c07077

PR-URL: nodejs#48787 Backport-PR-URL: nodejs#49174 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>

rluvaton force-pushed the backport-48787-to-v20.x branch from 2dca814 to 7c07077 Compare August 15, 2023 20:39

RafaelGSS force-pushed the v20.x-staging branch 2 times, most recently from 2a9aa46 to 21949c4 Compare August 17, 2023 11:48

rluvaton closed this Aug 17, 2023

rluvaton deleted the backport-48787-to-v20.x branch August 17, 2023 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

rluvaton commented Aug 14, 2023

nodejs-github-bot commented Aug 14, 2023

rluvaton Aug 15, 2023 •

edited

Loading

nodejs-github-bot commented Aug 15, 2023

nodejs-github-bot commented Aug 15, 2023

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

[v20.x backport] test: relocate test files fixtures for better understanding #48787 #49174

Conversation

rluvaton commented Aug 14, 2023

nodejs-github-bot commented Aug 14, 2023

rluvaton Aug 15, 2023 • edited Loading

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 15, 2023

nodejs-github-bot commented Aug 15, 2023

rluvaton Aug 15, 2023 •

edited

Loading