-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add h1 summary to security release process #49112
doc: add h1 summary to security release process #49112
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ba88713
to
97b946d
Compare
Commit Queue failed- Loading data for nodejs/node/pull/49112 ✔ Done loading data for nodejs/node/pull/49112 ----------------------------------- PR info ------------------------------------ Title doc: add h1 summary to security release process (#49112) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc/add-summary-to-security-release-process -> nodejs:main Labels doc Commits 1 - doc: add h1 summary to security release process Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/49112 Reviewed-By: Moshe Atlow Reviewed-By: Matteo Collina Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49112 Reviewed-By: Moshe Atlow Reviewed-By: Matteo Collina Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: add h1 summary to security release process ℹ This PR was created on Fri, 11 Aug 2023 21:13:42 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575388082 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575728794 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1577361439 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5861382314 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 3af6585 |
PR-URL: #49112 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #49112 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#49112 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#49112 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This has proven quite useful to either request disclosure on H1 and create the pos release announcement.