[v18.x backport] test_runner: align stdout and std error with and without --test
#48684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
MoLow
changed the title
--test
MoLow
force-pushed
the
backport-align-stdout
branch
2 times, most recently
from
2042910 to
1ac9c1d
Compare
PR-URL: nodejs#48034 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48057 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#48428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow
force-pushed
the
backport-align-stdout
branch
from
1ac9c1d to
c8cd582
Compare
github-actions
bot
removed
the
request-ci
danielleadams
approved these changes
Jul 10, 2023
|
@danielleadams , yes. It is https://github.com/nodejs/node/pull/48057/commits which contains two commits |
danielleadams
pushed a commit
that referenced
this pull request
Jul 12, 2023
PR-URL: #48034 Backport-PR-URL: #48684 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 12, 2023
PR-URL: #48057 Backport-PR-URL: #48684 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 12, 2023
PR-URL: #48057 Backport-PR-URL: #48684 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 12, 2023
PR-URL: #48428 Backport-PR-URL: #48684 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
Landed in a2bfe02...5d910ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #48057, #48034 and #48428