fs: fs.cp() should try copy-on-write if the platform supports it #47074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fs.cp()` and `fs.cpSync()` should use `fs.constants.COPYFILE_FICLONE` mode flag to try to use copy-on-write for copying a file if the platform supports its operation.
nodejs-github-bot
added
fs
cjihrig
reviewed
Mar 13, 2023
| @@ -226,7 +229,7 @@ function mayCopyFile(srcStat, src, dest, opts) { | |||
| } | |||
|
|
|||
| function copyFile(srcStat, src, dest, opts) { | |||
| copyFileSync(src, dest); | |||
| copyFileSync(src, dest, COPYFILE_FICLONE); | |||
There was a problem hiding this comment.
This seems like something that users should pass in via cp()'s options argument, and not something that Node core sets unconditionally.
There was a problem hiding this comment.
Okay. I withdeaw this pr. Thank you for your review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.cp()andfs.cpSync()should usefs.constants.COPYFILE_FICLONEmode flag to try copy-on-write for copying a file if the platform supports its operation.