module: Remove unused code

[zeusdeux]

Remove unused requireRepl code.
It was deprecated after 5.1.x.

This is with reference to #4642.

[benjamingr]

Fwiw - This is a breaking change. I don't really see the rush in removing it after it got a deprecation notice.

[mscdex]

I agree, the deprecation notice was only added in November in ee72ee7. I think we would remove this in 7.0?

[cjihrig]

Maybe we should add the future label and come back to this once the 6.x branch has been cut.

[zeusdeux]

@mscdex The deprecation notice was added after 5.1.x and before 5.2.x and since master right now is 6.0.0-pre, I assumed I could clean it up as per the deprecation rules node follows. Also, since it was mentioned in #4642, I went ahead and removed it in preparation for 6.0.

[mscdex]

@zeusdeux I could be wrong, but I was under the assumption that the current "deprecation policy" was to have a deprecation for the duration of (at least) one full major version before removal.

That said, this could still be pushed to master, but just not pulled in/released until 7.0.

[jasnell]

@chrisdickinson ... can we possibly get some information on if the removed method is used at all in modules?

[benjamingr]

I checked before my first comment through GH code search. It appears in multiple npm and GH repos. Not a very high amount but it does appear in some ones with ~10 stars.

Mostly, I don't really see the need to remove it - the benefit in removing deprecated methods is that it simplifies the code base and makes things easier for developers - not really the case here. To compare, no one is even considering removing fs. exists (and rightly so)

[jasnell]

If there are modules using it, I'd say there's no harm in keeping it for at least a while longer.

[jasnell]

given the comments on this one, I'm inclined to close. We can revisit it later.