Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update main branch name in src/README #43442

Merged
merged 1 commit into from
Jun 17, 2022
Merged

doc: update main branch name in src/README #43442

merged 1 commit into from
Jun 17, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 16, 2022

Refs: #33864

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 16, 2022
@panva panva added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 16, 2022
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43442
✔  Done loading data for nodejs/node/pull/43442
----------------------------------- PR info ------------------------------------
Title      doc: update main branch name in src/README (#43442)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:readme/main -> nodejs:main
Labels     doc, fast-track, author ready
Commits    1
 - doc: update main branch name in src/README
Committers 1
 - F3n67u 
PR-URL: https://github.com/nodejs/node/pull/43442
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43442
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Jun 2022 02:56:06 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008498544
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008540292
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008814801
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43442#pullrequestreview-1009053997
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2512076678

@aduh95 aduh95 merged commit 2887b1b into nodejs:main Jun 17, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 17, 2022

Landed in 2887b1b

@F3n67u F3n67u deleted the readme/main branch June 17, 2022 07:51
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: remove branch name mention in src/README.md
7f406fd 
PR-URL: #43442
Refs: #33864
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@F3n67u @targos
doc: remove branch name mention in src/README.md
0a87505 
PR-URL: #43442
Refs: #33864
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: remove branch name mention in src/README.md
18789d5 
PR-URL: #43442
Refs: #33864
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: remove branch name mention in src/README.md
cb0977f 
PR-URL: nodejs/node#43442
Refs: nodejs/node#33864
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@F3n67u @nodejs-github-bot @aduh95 @lpinca @richardlau @RaisinTen @VoltrexKeyva @panva