-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add @RaisinTen to the TSC #41419
Conversation
I'll land once I get through the onboarding steps (assuming there are enough approvals/waiting time is complete by then) |
Believe we can fast track this. |
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have the vote directory in nodejs/tsc
, should we create that PR first and then reference it here?
Although I guess the json is mostly for bookkeeping, since the vote happens in the issue thread... which makes me think, should our votes just be PRs against the TSC repo? Would simplify the automation too.
Edit: I suppose upon further reflection, a decent % of our votes are not binary which would make the PR format not particularly helpful.
(updated the title to match the other PR, there was an error in the name) |
@mhdawson The commit title would need to be updated as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! 🎉
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]>
@richardlau fixed |
Ok, added to all required groups, created PRs to add to emails. |
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Landed in 46f4d5e |
@RaisinTen Welcome ! |
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Refs: nodejs/TSC#1141
Signed-off-by: Michael Dawson [email protected]