Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix command name in benchmark scripts #410

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions benchmark/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Node.js core benchmark tests
# io.js core benchmark tests

This folder contains benchmark tests to measure the performance for certain
Node.js APIs.
io.js APIs.

## How to run tests

Expand All @@ -10,7 +10,7 @@ There are two ways to run benchmark tests:
1. Run all tests of a given type, for example, buffers

```sh
node benchmark/common.js buffers
iojs benchmark/common.js buffers
```

The above command will find all scripts under `buffers` directory and require
Expand Down Expand Up @@ -70,7 +70,7 @@ buffers/buffer-read.js noAssert=false buffer=fast type=UInt16BE millions=1: 244.
2. Run an individual test, for example, buffer-slice.js

```sh
node benchmark/buffers/buffer-read.js
iojs benchmark/buffers/buffer-read.js
```
The output:
```
Expand Down
2 changes: 1 addition & 1 deletion benchmark/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports.PORT = process.env.PORT || 12346;
if (module === require.main) {
var type = process.argv[2];
if (!type) {
console.error('usage:\n ./node benchmark/common.js <type>');
console.error('usage:\n ./iojs benchmark/common.js <type>');
process.exit(1);
}

Expand Down
6 changes: 3 additions & 3 deletions benchmark/http-flamegraph.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
cd "$(dirname "$(dirname $0)")"

node=${NODE:-./node}
node=${NODE:-./iojs}

name=${NAME:-stacks}

Expand All @@ -22,7 +22,7 @@ fi
ulimit -n 100000
$node benchmark/http_simple.js &
nodepid=$!
echo "node pid = $nodepid"
echo "iojs pid = $nodepid"
sleep 1

# has to stay alive until dtrace exits
Expand Down Expand Up @@ -62,7 +62,7 @@ echo 'Turn the stacks into a svg'
stackvis dtrace flamegraph-svg < "$name".src > "$name".raw.svg

echo 'Prune tiny stacks out of the graph'
node -e '
iojs -e '
var infile = process.argv[1];
var outfile = process.argv[2];
var output = "";
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if [ "$k" = "no" ]; then
else
k="-k"
fi
node=${NODE:-./node}
node=${NODE:-./iojs}

$node benchmark/http_simple.js &
npid=$!
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http_simple_bench.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if [ ! -d benchmark/ ]; then
fi

if [ $SERVER == "127.0.0.1" ]; then
./node benchmark/http_simple.js &
./iojs benchmark/http_simple.js &
node_pid=$!
sleep 1
fi
Expand Down
2 changes: 1 addition & 1 deletion benchmark/plot.R
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ab.load <- function (filename, name) {


filename <- args[0:1]
data <- ab.load(filename, "node")
data <- ab.load(filename, "iojs")


# histogram
Expand Down