-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12.x backport] module: fix legacy node
specifier resolution to resolve "main"
field
#39497
Closed
aduh95
wants to merge
1
commit into
nodejs:v12.x-staging
from
aduh95:backport-node-specifier-resolver-fix
Closed
[v12.x backport] module: fix legacy node
specifier resolution to resolve "main"
field
#39497
aduh95
wants to merge
1
commit into
nodejs:v12.x-staging
from
aduh95:backport-node-specifier-resolver-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@aduh95 Test failures
|
61c274b
to
6ac4a9b
Compare
69b2eae
to
5f22ec4
Compare
cc @nodejs/modules |
guybedford
approved these changes
Jul 23, 2021
632a3ae
to
1b7af5b
Compare
PR-URL: nodejs#38979 Fixes: nodejs#32103 Fixes: nodejs#38739 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
5f22ec4
to
43724ac
Compare
richardlau
approved these changes
Jul 28, 2021
richardlau
pushed a commit
that referenced
this pull request
Jul 28, 2021
PR-URL: #38979 Backport-PR-URL: #39497 Fixes: #32103 Fixes: #38739 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Landed in f0bb3d2 |
richardlau
pushed a commit
that referenced
this pull request
Jul 28, 2021
PR-URL: #38979 Backport-PR-URL: #39497 Fixes: #32103 Fixes: #38739 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias [email protected]
Reviewed-By: Guy Bedford [email protected]