Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] Backport V8 changes to remove set_sources_assignment_filter #39244

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 7c182bd65f42
Original commit message:

    Fix visiblity rules for configs enforced by the latest GN version.

    Prior versions of GN had a bug (gn:22) where visibility rules
    for configs weren't being enforced properly.

    This CL tweaks the visibility settings of some configs to
    conform to the latest version.

    Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
    Commit-Queue: Dirk Pranke <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#69463}

Refs: v8/v8@7c182bd
  • Loading branch information
targos committed Jul 9, 2021
commit 959b466f97a3a472ee36a06bdd0de1491c207a26
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.69',
'v8_embedder_string': '-node.70',

##### V8 defaults for Node.js #####

Expand Down
12 changes: 8 additions & 4 deletions deps/v8/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ v8_toolset_for_shell = "host"
#

config("internal_config_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

configs = [ ":v8_tracing_config" ]

Expand All @@ -321,7 +322,8 @@ config("internal_config_base") {

config("internal_config") {
defines = []
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

configs = [
"//build/config/compiler:wexit_time_destructors",
Expand Down Expand Up @@ -429,7 +431,8 @@ config("v8_header_features") {
# Put defines here that are only used in our internal files and NEVER in
# external headers that embedders (such as chromium and node) might include.
config("features") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

defines = []

Expand Down Expand Up @@ -559,7 +562,8 @@ config("features") {
}

config("toolchain") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
# Only targets in this file and its subdirs can depend on this.
visibility = [ "./*" ]

defines = []
cflags = []
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/third_party/inspector_protocol/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import("../../gni/v8.gni")

config("crdtp_config") {
visibility = [ "../../src/inspector:*" ]
visibility = [ "../../src/inspector:*", ":*" ]
configs = [ "../../:internal_config" ]
include_dirs = [ "../../include" ]
}
Expand Down