Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.22.0 proposal #37797

Merged
merged 17 commits into from
Mar 30, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add cpu-profiler-crash test
This test is added as it usually crashes without applying the v8 patch:
v8/v8@beebee4

PR-URL: #37293
Backport-PR-URL: #37578
Refs: v8/v8@beebee4
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
santigimeno authored and richardlau committed Mar 15, 2021
commit 0f6d44500cf9395c39b39f1d31855864db12b6fe
16 changes: 16 additions & 0 deletions test/addons/cpu-profiler-crash/binding.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#include "node.h"
#include "v8.h"
#include "v8-profiler.h"

static void StartCpuProfiler(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::CpuProfiler* profiler = v8::CpuProfiler::New(args.GetIsolate());
v8::Local<v8::String> profile_title = v8::String::NewFromUtf8(
args.GetIsolate(),
"testing",
v8::NewStringType::kInternalized).ToLocalChecked();
profiler->StartProfiling(profile_title, true);
}

NODE_MODULE_INIT(/* exports, module, context */) {
NODE_SET_METHOD(exports, "startCpuProfiler", StartCpuProfiler);
}
9 changes: 9 additions & 0 deletions test/addons/cpu-profiler-crash/binding.gyp
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
'targets': [
{
'target_name': 'binding',
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
20 changes: 20 additions & 0 deletions test/addons/cpu-profiler-crash/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
'use strict';

// This test crashes most of the time unless the v8 patch:
// https://github.com/v8/v8/commit/beebee4f80ff2eb91187ef1e8fa00b8ff82a20b3
// is applied.
const common = require('../../common');
const bindings = require(`./build/${common.buildType}/binding`);

function fn() { setImmediate(fn); }
setInterval(function() {
for (let i = 0; i < 1000000; i++)
fn();
clearInterval(this);
setTimeout(process.reallyExit, 2000);
}, 0);


setTimeout(() => {
bindings.startCpuProfiler();
}, 1000);