Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-fs-stream-construct #34203

Merged
merged 25 commits into from
Jul 7, 2020
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b1750a4
quic: continued refactoring for quic_stream/quic_session
jasnell Jul 1, 2020
b5bf5bb
quic: refactor native object flags for better readability
jasnell Jul 1, 2020
f7510ca
quic: additional cleanups on the c++ side
jasnell Jul 1, 2020
f9c2245
quic: refactor QuicSession close/destroy flow
jasnell Jul 1, 2020
3acdd6a
quic: refactor QuicSession shared state to use AliasedStruct
jasnell Jul 1, 2020
e4d369e
quic: remove onSessionDestroy callback
jasnell Jul 2, 2020
7b062ca
quic: refactor qlog handling
jasnell Jul 2, 2020
3837d9c
quic: fixup lint issues
jasnell Jul 2, 2020
5a87e9b
quic: cleanup timers if they haven't been already
jasnell Jul 3, 2020
1b1e985
quic: add missing memory tracker fields
jasnell Jul 3, 2020
e7dadd3
doc: specify how fs.WriteStream/ReadStreams are created
jasnell Jul 3, 2020
d4f6900
src: add TimerWrap utility
jasnell Jul 3, 2020
e19a251
src: replace InspectorTimer with TimerWrap utility
jasnell Jul 3, 2020
0f97d60
quic: use TimerWrap for idle and retransmit timers
jasnell Jul 3, 2020
8a57788
doc: move gibfahn to emeritus
Trott Jul 4, 2020
7eb500b
doc: move digitalinfinity to emeritus
Trott Jul 4, 2020
654df09
doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors
Trott Jul 4, 2020
82c435d
src: fix unused namespace member
branisha Jul 5, 2020
67ba825
src: fix minor comment typo in KeyObjectData
danbev Jul 2, 2020
ddfaafa
repl: fix verb conjugation in deprecation message
Trott Jul 4, 2020
9f0671e
test: replace deprecated function call from test-repl-history-navigation
Trott Jul 4, 2020
bf77289
doc: remove errors that were never released
Trott Jul 4, 2020
3975799
doc: replace http to https of link urls
sapics Jun 29, 2020
ee3416b
lib: replace http to https of comment link urls
sapics Jun 29, 2020
772fdb0
test: fix flaky test-fs-stream-construct
Trott Jul 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: cleanup timers if they haven't been already
PR-URL: #34160
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
jasnell committed Jul 5, 2020
commit 5a87e9b0a5830824f90b5bf3742370c167619b71
7 changes: 7 additions & 0 deletions src/quic/node_quic_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1468,6 +1468,13 @@ QuicSession::~QuicSession() {
if (listener_ == listener())
RemoveListener(listener_);

// Stop and free the idle and retransmission timers if they are active.
// In a clean shutdown, using Close(), these will have already been
// stopped, but if Close() was not called and we're being destroyed
// in GC, for instance, we need to make sure they get stopped here.
StopIdleTimer();
StopRetransmitTimer();

DebugStats();
}

Expand Down