doc: add allowed info strings to style guide #34024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @nodejs/documentation Although not 100% content with the solution we have implemented for this uniformity problem, IMO a more DX-friendly solution would be ideal. This should probably be seen as an initial iteration on a fix using the tools that were at our disposal. I would be interested in collaborating on an iteration of this and proposing a more elegant solution in the future. |
addaleax
approved these changes
Jun 23, 2020
Trott
reviewed
Jun 23, 2020
Trott
approved these changes
Jun 23, 2020
Trott
added
the
author ready
jasnell
approved these changes
Jun 23, 2020
lpinca
approved these changes
Jun 23, 2020
|
Please 👍 for fast-track |
|
Landed in e405e82 |
Trott
pushed a commit
that referenced
this pull request
Jun 25, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 12, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: #33510 Refs: #33507 Refs: #33483 Refs: #33531 Refs: #33542 Refs: #33028 Refs: #33548 Refs: #33486 PR-URL: #34024 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
DerekNonGeneric
added a commit
to DerekNonGeneric/remark-preset-lint-node
that referenced
this pull request
Jul 17, 2020
These instructions are relevant due to nodejs/node#34024.
Trott
pushed a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Aug 3, 2020
…ns (#132) These instructions are relevant due to nodejs/node#34024.
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
…ns (#132) These instructions are relevant due to nodejs/node#34024.
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
…ns (#132) These instructions are relevant due to nodejs/node#34024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the list of agreed-upon info strings to the
documentation style guide to aid with future development and
maintenance.
Refs: #33510
Refs: #33507
Refs: #33483
Refs: #33531
Refs: #33542
Refs: #33028
Refs: #33548
Refs: #33486
Checklist