Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.3.0 proposal #33452

Merged
merged 104 commits into from
May 19, 2020
Merged
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
676ef95
test: add tests for options.fs in fs streams
julianduque May 1, 2020
c5a38fe
doc: fix style and grammer in buffer.md
seishun May 1, 2020
cc02c73
http: fixes memory retention issue with FreeList and HTTPParser
leidegre May 1, 2020
07372e9
doc: explicitly doc package.exports is breaking
MylesBorins Apr 26, 2020
a292630
src: retrieve binding data from the context
joyeecheung Apr 19, 2020
a56b600
Revert "src: add aliased-buffer-overflow abort test"
richardlau May 1, 2020
5ff3192
Revert "src: add test/abort build tasks"
richardlau May 1, 2020
cf47698
src: use BaseObjectPtr in StreamReq::Dispose
jasnell Apr 27, 2020
25443fa
doc: doc and test URLSearchParams discrepancy
jasnell May 4, 2020
cf88ed8
doc: update napi_async_init documentation
mhdawson Apr 30, 2020
b2fb01a
stream: make from read one at a time
ronag May 1, 2020
4ae6130
n-api: add uint32 test for -1
May 5, 2020
0572943
doc: add warnings about transferring Buffers and ArrayBuffer
jasnell May 5, 2020
dab5c38
doc: remove AsyncWrap mentions from async_hooks.md
puzpuzpuz May 5, 2020
6ffec50
doc: add troubleshooting guide for AsyncLocalStorage
puzpuzpuz May 5, 2020
4465d23
wasi: prevent syscalls before start
tniessen May 4, 2020
2c49dd3
doc: specify unit of time passed to `fs.utimes`
SimenB May 4, 2020
c6a8cd0
doc: fix md issue in src/README.md
juanarbol May 3, 2020
5b42d81
doc: add Uint8Array to `end` and `write`
rexagod May 2, 2020
27b814c
module: lazy load 'getOptionValue' in initializeLoader
himself65 May 2, 2020
e20fe53
doc: update Buffer(size) documentation
seishun May 1, 2020
b5dcfbf
doc: removed unnecessary util imports from vm examples
WalasPrime Apr 30, 2020
84974d3
doc: mention python3-distutils dependency in BUILDING.md
osher Apr 30, 2020
6bca487
lib: fix grammar in internal/bootstrap/loaders.js
szTheory May 2, 2020
302408e
test: skip some console tests on dumb terminal
AdamMajer Apr 30, 2020
6f54c2b
test: rename test-lookupService-promises
rickyes Apr 27, 2020
a9e4fdb
doc: correct description of `decipher.setAuthTag` in crypto.md
jbuhacoff Apr 27, 2020
ed41494
src: clean up large pages code
May 5, 2020
6a26eee
wasi: fix poll_oneoff memory interface
cjihrig May 5, 2020
0cbee57
doc: add warning for socket.connect reuse
ronag May 5, 2020
ad86807
module: better error for named exports from cjs
MylesBorins May 5, 2020
548cedd
src: split out callback queue implementation from Environment
addaleax May 6, 2020
94d0a08
lib: refactored scheduling policy assignment
yashLadha Apr 5, 2020
0a78925
meta: add issue template for API reference docs
DerekNonGeneric Apr 20, 2020
ef25033
src: fix invalid windowBits=8 gzip segfault
bnoordhuis Apr 24, 2020
736ca65
zlib: reject windowBits=8 when mode=GZIP
bnoordhuis Apr 24, 2020
b634d4b
http: set IncomingMessage.destroyed
ronag Apr 28, 2020
41c5524
http2: add `bytesWritten` test for `Http2Stream`
rexagod Apr 21, 2020
eedc131
tls: reset secureConnecting on client socket
davedoesdev May 2, 2020
cae2051
buffer: improve copy() performance
seishun May 2, 2020
ba66b21
deps: upgrade npm to 6.14.5
ruyadorno May 4, 2020
398bdf4
perf_hooks: fix error message for invalid entryTypes
targos May 7, 2020
1d2c81f
test: add hr-time Web platform tests
targos May 7, 2020
804982c
tools: add eslint rule to only pass through 'test' to debuglog
BridgeAR Mar 9, 2020
cf03fe5
tools: remove obsolete no-restricted-syntax eslint rules
BridgeAR Mar 9, 2020
3de9dd9
src: remove unnecessary Isolate::GetCurrent() calls
addaleax May 8, 2020
a133a88
lib: fix typo in timers insert function comment
danbev May 8, 2020
e1e57a4
tools: update ESLint to 7.0.0
cjihrig May 8, 2020
cc5c8e0
http: don't destroy completed request
ronag Apr 28, 2020
b061655
async_hooks: move PromiseHook handler to JS
Qard Apr 16, 2020
f33e866
http: expose http.validate-header-name/value
osher Apr 28, 2020
1dcf66c
fs: add .ref() and .unref() methods to watcher classes
rickyes Apr 28, 2020
fd9c7c2
src: fix compiler warning in async_wrap.cc
addaleax May 9, 2020
0d77eec
src: add support for TLA
devsnek Nov 12, 2019
5b2cd44
test: fix test-net-throttle
Trott May 9, 2020
f3129b2
src: fix typo in comment in async_wrap.cc
danbev May 11, 2020
4f0cd64
doc: fix typo in n-api.md
danbev May 9, 2020
b41affb
doc: add note about clientError writable handling
ShogunPanda May 8, 2020
066ca98
src: use MaybeLocal.ToLocal instead of IsEmpty
danbev May 8, 2020
c9c16c0
src: delete unused variables to resolve compile time print warning
rickyes May 11, 2020
1999607
src: remove unused using declarations in node.cc
danbev May 6, 2020
d292633
src: add primordials to arguments comment
danbev May 9, 2020
331f0b3
deps: update to ICU 67.1
targos May 9, 2020
85cffb8
test: update WPT interfaces and hr-time
joyeecheung May 12, 2020
f31b262
test: refactor WPTRunner
joyeecheung May 6, 2020
7d4db35
build: fix `--error-on-warn` for macOS
richardlau May 11, 2020
34e7400
build: enable `--error-on-warn` for POSIX workflows
richardlau May 11, 2020
fd89ef1
src: refactor Reallocate since it introduced in upstream v8
gengjiawen Apr 10, 2020
6d2aaaf
tls: fix --tls-keylog option
mildsunrise May 12, 2020
354ff4f
src: small modification to NgHeader
jasnell May 7, 2020
0ffa040
doc: add examples for implementing ESM
rosaxxny Apr 30, 2020
0257386
src: remove deprecated FinalizationRegistry hooks
devsnek May 12, 2020
1a9771a
repl: improve repl preview
BridgeAR May 4, 2020
d33dcf1
repl: show reference errors during preview
BridgeAR May 4, 2020
69061dc
repl: replace hard coded core module list with actual list
BridgeAR May 7, 2020
95842db
test: refactor test/parallel/test-bootstrap-modules.js
BridgeAR May 7, 2020
6257cf2
repl: improve repl autocompletion for require calls
BridgeAR May 7, 2020
c2d2dfc
module: do not check circular dependencies for exported proxies
BridgeAR May 10, 2020
c2cf978
Revert "vm: add importModuleDynamically option to compileFunction"
mcollina May 12, 2020
d3e2fc8
test: fix test-dns-idna2008
Trott May 12, 2020
182aaf5
doc: enhance guides by fixing and making grammar more consistent
ChrisAHolland Apr 29, 2020
12391c7
fs: clean up Dir.read() uv_fs_t data before calling into JS
addaleax May 6, 2020
c7c420e
fs: forbid concurrent operations on Dir handle
addaleax May 7, 2020
2dc5db8
cli: add `--trace-atomics-wait` flag
addaleax Dec 5, 2019
b1a7fda
worker: call CancelTerminateExecution() before exiting Locker
addaleax May 10, 2020
dd4789b
async_hooks: clear async_id_stack for terminations in more places
addaleax May 11, 2020
b93a723
test: regression tests for async_hooks + Promise + Worker interaction
addaleax May 10, 2020
8ada953
src: replace to CHECK_NOT_NULL in node_crypto
himself65 May 13, 2020
8f91338
doc: fix stream example
addaleax May 15, 2020
35aae31
module: add specific error for dir import
aduh95 May 3, 2020
e53de96
esm: improve commonjs hint on module not found
aduh95 May 14, 2020
9119344
tools: enable no-else-return lint rule
lpinca Apr 8, 2020
db7bb94
repl: deprecate repl.inputStream and repl.outputStream
BridgeAR May 7, 2020
ed83202
repl: remove obsolete completer variable
BridgeAR May 7, 2020
7aa581f
repl: deprecate repl._builtinLibs
BridgeAR May 7, 2020
5e5aa0b
src: add #include <string> in json_utils.h
zcbenz May 10, 2020
9d1e577
worker: fix crash when .unref() is called during exit
addaleax May 14, 2020
099f18e
src: distinguish refed/unrefed threadsafe Immediates
addaleax May 9, 2020
24faa37
buffer,n-api: release external buffers from BackingStore callback
addaleax May 9, 2020
7f9ccd6
doc: fix extension in esm example
devsnek May 14, 2020
cc27949
doc: prepare 14.x changelog for remark update
Trott May 15, 2020
453affe
tools: update dependencies for markdown linting
Trott May 15, 2020
e4ad464
src: add default: case to silence compiler warning
addaleax May 18, 2020
5d81e4d
2020-05-19, Version 14.3.0 (Current)
codebytere May 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
n-api: add uint32 test for -1
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for
-1.

Re: #33117
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
  • Loading branch information
Gabriel Schulhof authored and codebytere committed May 7, 2020
commit 4ae613001086d4efb3a20a10dfc3c1e3c013e8a0
1 change: 1 addition & 0 deletions test/js-native-api/test_number/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ testUint32(4294967295);
testUint32(4294967296, 0);
testUint32(4294967297, 1);
testUint32(17 * 4294967296 + 1, 1);
testUint32(-1, 0xffffffff);

// Validate documented behavior when value is retrieved as 32-bit integer with
// `napi_get_value_int32`
Expand Down