src: refactor Reallocate since it introduced in upstream v8 #32716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
changed the title
addaleax
approved these changes
Apr 8, 2020
cjihrig
approved these changes
Apr 8, 2020
Flarna
approved these changes
Apr 9, 2020
|
@targos Can I directly merge this |
|
You can merge. CI is not guaranteed to pass with canary. |
mmarchini
pushed a commit
that referenced
this pull request
Apr 13, 2020
ryzokuken
pushed a commit
that referenced
this pull request
Apr 17, 2020
ryzokuken
pushed a commit
that referenced
this pull request
Apr 21, 2020
targos
pushed a commit
that referenced
this pull request
Apr 25, 2020
ryzokuken
pushed a commit
that referenced
this pull request
May 2, 2020
targos
pushed a commit
that referenced
this pull request
May 9, 2020
ryzokuken
pushed a commit
that referenced
this pull request
May 12, 2020
targos
pushed a commit
that referenced
this pull request
May 13, 2020
targos
pushed a commit
that referenced
this pull request
May 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is target to branch
canary-baseOriginal PR in: nodejs/node-v8#154.
V8 introduced this api in it's own.
See https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes