[v13.x backport] zlib: align with streams #32371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v13.x
zlib
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once. PR-URL: nodejs#32220 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Backport-PR-URL: nodejs#32371
ronag
force-pushed
the
backport-32220-to-v13.x
branch
from
dc563f1 to
76fd0e5
Compare
|
also there are a ton of failures PTAL |
|
I think most of the failures is due to the fact we don't emit |
ronag
commented
Mar 19, 2020
| ts.on('close', common.mustCall(() => { | ||
| ts.close(common.mustCall()); | ||
| })); | ||
| ts.on('close', common.mustCall()); |
There was a problem hiding this comment.
finished does not invoke callback on closed stream, this was a semver-major fix does not land on 13
ronag
commented
Mar 19, 2020
| name: 'Error', | ||
| message: 'Cannot call write after a stream was destroyed' | ||
| } | ||
| ); |
There was a problem hiding this comment.
I'm a little unsure how exactly this could throw before.
ronag
commented
Mar 19, 2020
| assert.throws( | ||
| () => gunzip.write({}), | ||
| TypeError | ||
| ); |
There was a problem hiding this comment.
I'm a little unsure how exactly this could throw before.
|
PR was just labeled as semver-major so I guess this should not be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #32220
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes