v11.14.0 proposal #27163
Merged
v11.14.0 proposal #27163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <[email protected]>
* header explicit usage, order, and reduce use of `*-inl.h` * pointer -> const reference when possible * no variable recyclicng * `std::begin/end` prefered over `instance.begin/end` * `USE` for explicit unused resaults Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #26476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: #26513 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Coe <[email protected]>
PR-URL: #26513 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Coe <[email protected]>
Since these depends on process runtime states, delay them until pre-execution. PR-URL: #26517 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap. PR-URL: #26517 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #26650 PR-URL: #26548 Refs: #26546 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #26493 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Use a RAII approach by default, and make it possible for embedders to use the `ArrayBufferAllocator` directly as a V8 `ArrayBuffer::Allocator`, e.g. when passing to `Isolate::CreateParams` manually. PR-URL: #26525 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Split the API up into its essential parts, namely setting up the creation parameters for the Isolate, creating it, and performing Node.js-specific customization afterwards. PR-URL: #26525 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Instead of patching process._breakFirstLine to inform the JS land to wait for the debugger, check that the JS land has not yet serialized the options and then patch the debug options from C++. The changes will be carried into JS later during option serialization. PR-URL: #26602 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #26769 Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #26810 Refs: #26546 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Another nail in the coffin here, farewell ye ol C-style apis. These apis caused numerous other issues that required far too many safeguards. This gets us one step closer to not having to worry about those issues anymore. Refs: #18066 Refs: #20298 PR-URL: #26760 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #26814 Refs: #26546 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Masashi Hirano <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
PR-URL: #26783 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Instead of relying on the value of the CLI option when executing bootstrap/loaders.js. PR-URL: #26759 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
In the current code, line 497 checks if `item` is `null` or `undefined`.
However, `item` is guaranteed to be a non-null object or function at
that point.
* Lines 484/485 set `primitive` to `true` if `item` is null or
undefined.
* Line 486 skips line 497 if `primitive` is true (which it will always
be if `item` is null or undefined) and `properties` is undefined. So
the only way to get to line 497 when `item` is null or undefined is if
`properties` is specified.
* Line 494 skips line 497 if `primitive` is true (which it will always
be if `item` is null or undefined) and `properties` are specified
(which will always be the case or else this `else` block is skipped.)
Here are the current lines 484 through 497:
const primitive = item === null ||
(typeof item !== 'function' && typeof item !== 'object');
if (properties === undefined && primitive) {
hasPrimitives = true;
valuesKeyArray[i] = _inspect(item);
} else {
const keys = properties || ObjectKeys(item);
for (const key of keys) {
if (map[key] === undefined)
map[key] = [];
if ((primitive && properties) || !hasOwnProperty(item, key))
map[key][i] = '';
else
map[key][i] = item == null ? item : _inspect(item[key]);
This change removes the unnecessary ternary in that final line,
simplifying it to:
map[key][i] = _inspect(item[key]);
PR-URL: #26906
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
PR-URL: #26898 Refs: #24928 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #26815 Reviewed-By: Refael Ackermann <[email protected]>
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module. PR-URL: #26912 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This fixes the parse function for single character input that are not a path separator. PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #26591 Reviewed-By: Ruben Bridgewater <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
When console.log is called for the first time it initializes TTYWrap object. However, if there is not enough space on the V8 stack, creating function template fails and triggers empty maybe local exception. PR-URL: #26832 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
PR-URL: #27041 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Cleanup some code and make the emit hooks very slightly faster. PR-URL: #27034 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
It was reported that parallel builds on Windows sometimes error because of missing intermediate files. On closer inspection I noticed that some files are copied from src/ to the intermediate build directory in a way where they don't participate in dependency resolution. Put another way, the build system doesn't know to wait for the copy to complete because we don't tell it to. Fix that by not copying around files but instead making the script that processes them a little smarter about where to find them and where to store the results. PR-URL: #27026 Fixes: #27025 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Richard Lau <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
PR-URL: #27041 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Refs: #26982 PR-URL: #27164 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs
force-pushed
the
v11.14.0-proposal
branch
from
369e566 to
ebfb67a
Compare
BethGriggs
added a commit
that referenced
this pull request
Apr 10, 2019
Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163
richardlau
approved these changes
Apr 10, 2019
targos
approved these changes
Apr 10, 2019
cjihrig
approved these changes
Apr 10, 2019
|
Still triaging CITGM failures - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1812/testReport/
@targos, @BridgeAR have you seen any of these fail/be flaky on previous releases? |
These two look like nodejs/citgm#652
npm ERR! C:\Program Files\Git\mingw64/libexec/git-core\git-submodule: line 19: .: git-sh-setup: file not foundGit setup issue? @nodejs/build
¯\_(ツ)_/¯ |
|
|
Looks very very strange... I keep getting git timeouts, so this might be a network issue... |
|
I imagine |
Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163
BethGriggs
force-pushed
the
v11.14.0-proposal
branch
from
ebfb67a to
cd026f8
Compare
BethGriggs
added a commit
that referenced
this pull request
Apr 11, 2019
Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Apr 11, 2019
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
Commits
ca7c4f485b] - async_hooks: minor cleanup and improvements (Anatoli Papirovski) #27034e9bffa8166] - benchmark: improve module-loader benchmark (Ruben Bridgewater) #2697009d6dfb21d] - benchmark: add new module loading benchmarks (Ruben Bridgewater) #269705512ecb5b0] - benchmark: tidy up eslint ignore in foreach-bench.js (gengjiawen) #26925de937375e4] - benchmark: remove unused field in class BenchmarkProgress (gengjiawen) #269250aea4d1c77] - benchmark,lib: change var to const (Ruben Bridgewater) #269152ba58a6d54] - buffer: fix concat error message (Ruben Bridgewater) #27050a64786f47f] - build: fix inspector dependency resolution (Ben Noordhuis) #2702619a30f3b7e] - build: fix inspector dependency resolution (Ben Noordhuis) #27026ab5dbf9eb0] - build: only emit download ICU warnings once (Richard Lau) #270317fe43bd81a] - build: remove unused label from vcbuild.bat (Ben Noordhuis) #269016cbd6b5d57] - build: fix skipping of flaky tests on Travis (Richard Lau) #27002769d12ca9f] - build: add aPrepare ccachejob in Travis (Richard Lau) #27002d8aaf2e0db] - build,meta: tweak Travis config (Refael Ackermann) #26969b64b22377c] - build,win: silence MSVC warning C4129 for V8 (Refael Ackermann) #2701723967431f5] - child_process: doc deprecate ChildProcess._channel (cjihrig) #269824defe47228] - child_process: reduce internal usage of public require of util (toshi1127) #26769e43dbaaba4] - console: remove unreachable code (Rich Trott) #269062b791d8697] - crypto: fix crash of encrypted private key export without cipher (Filip Skokan) #270411d2f4c4c6f] - crypto: fix crash of encrypted private key export without cipher (Filip Skokan) #2704198552f3630] - crypto: allow undefined for saltLength and padding (Tobias Nießen) #26921db7df0fb12] - deps: add ARM64 Windows configurations in openssl (Jon Kunkee) #26001341eacc949] - deps: add ARM64 Windows support in openssl (Shigeki Ohtsu) #26001247700f293] - (SEMVER-MINOR) deps: update nghttp2 to 1.37.0 (gengjiawen) #26990af3ce38902] - dns: refactor lib/internal/dns/utils.js (Rich Trott) #27006ac12109d14] - (SEMVER-MINOR) dns: make dns.promises enumerable (cjihrig) #26592d3c1de313e] - (SEMVER-MINOR) dns: remove dns.promises experimental warning (cjihrig) #26592ff126ea13c] - doc: assign missed deprecation code (Richard Lau) #2716451dad0aaca] - doc: fix default maxBuffer size (kohta ito) #228947eb73d301d] - doc: document the 'pause' and 'resume' events (Luigi Pinca) #2699957ced2db8c] - doc: remove unnecessary intro in governance doc (Rich Trott) #27036a5314a1af1] - doc: remove old system_errors (Minwoo Jung) #270372d780f864b] - doc: unify link formatting in buffer.md (Vse Mozhet Byt) #270306e3b6c5e2c] - doc: unify periods in comments in buffer.md (Vse Mozhet Byt) #270305983cefbf9] - doc: add notes about negative offsets in buffer.md (Vse Mozhet Byt) #270303567ff1378] - doc: mark optional parameters in buffer.md (Vse Mozhet Byt) #27030eeee6360b9] - doc: add note about Buffer octets integer coercion (Vse Mozhet Byt) #27030c3d573d743] - doc: fix error notes inBuffer.from()variants (Vse Mozhet Byt) #27030e18a0e8087] - doc: unify number/integer types in buffer.md (Vse Mozhet Byt) #270300d75adcd71] - doc: add missing types in buffer.md (Vse Mozhet Byt) #27030231eff92ca] - doc: fix possible typo in buffer.md (Vse Mozhet Byt) #27030f475e79db3] - doc: remove description duplication in buffer.md (Vse Mozhet Byt) #270307b37c65914] - doc: improve the doc of the 'information' event (Luigi Pinca) #27009c4b790b62b] - doc: move "Prints: ..." under the code (simon3000) #270350f08a8e081] - doc: add information about modules cache behavior (Ruben Bridgewater) #26971b88871e80b] - doc: list when promiseResolve hook was added to async_hooks (Thomas Watson) #269787a391961ea] - doc: change code lang and update it with latest Node.js (gengjiawen) #2698717cc117f4a] - doc: update changelog for v10.x LTS (Beth Griggs) #2693128efecccd5] - doc: remove "How is an LTS release cut?" section (Rich Trott) #26955d76c30c082] - doc: add note about mkdtemp() platform differences (cjihrig) #269444a7a84a6be] - (SEMVER-MINOR) doc: move dns.promises to stable status (cjihrig) #2659225d5198001] - doc: change links to https in benchmark guide (gengjiawen) #26925a821a96b50] - doc: correct typo: cert.issuerCertificate (Steven R. Loomis)17bff5ca0d] - doc: remove reference to "credentials object" (Sam Roberts) #269085e64acd66b] - (SEMVER-MINOR) embedding: makeNewIsolate()API more flexible (Anna Henningsen) #265257671a65dbb] - (SEMVER-MINOR) embedding: refactor publicArrayBufferAllocatorAPI (Anna Henningsen) #26525c756b84447] - errors: make range mandatory in ERR_OUT_OF_RANGE (Ruben Bridgewater) #269243e386a77d5] - (SEMVER-MINOR) fs: remove experimental warning for fs.promises (Anna Henningsen) #26581bb9f1cce42] - fs: reduce usage of require('util') (toshi1127) #267835a29a94f0e] - http: reduce usage of public util (ZYSzys) #26548760d089e92] - inspector: display error when ToggleAsyncHook fails (Joyee Cheung) #268591b45704c19] - inspector: patch C++ debug options instead of process._breakFirstLine (Joyee Cheung) #26602100bfc5131] - meta: move ofrobots to TSC emeritus (Ali Ijaz Sheikh) #270765c39687d01] - module: add extra caching layer (Ruben Bridgewater) #269709b27d5eebb] - module: add path to the module object (Ruben Bridgewater) #269703263264f43] - module: inline try catch (Ruben Bridgewater) #26970079368a6ab] - module: fix repl require calling the same file again (Ruben Bridgewater) #269283c9292642d] - module: simpler esm loading (Ruben Bridgewater) #26974fd8de13bbe] - path: refactor for less indentation (Ruben Bridgewater) #26917b62739c85c] - path: remove dead code (Ruben Bridgewater) #26916bd006e1002] - path: fix win32 parse regression (Ruben Bridgewater) #26912a232cd60dd] - process: store argv in Environment (Joyee Cheung) #269454d06ef468e] - process: run RunBootstrapping in CreateEnvironment (Joyee Cheung) #26788a03552d246] - process: handle --expose-internals during pre-execution (Joyee Cheung) #2675975c5d9c5b7] - process: create legacy process properties during pre-execution (Joyee Cheung) #26517d4f95091d0] - process: delay process.argv[0] and process.argv0 handling (Joyee Cheung) #265176c40f7f940] - querystring: simplify stringify method (ZYSzys) #26591dbd06088cf] - (SEMVER-MINOR) readline: make Symbol.asyncIterator support stable (Matteo Collina) #2698978fad3210c] - readline: replace quadratic regex with linear one (Thomas) #26778003e085ab5] - report: add cwd to report (cjihrig) #27022755609c682] - src: prevent crash in TTYWrap::Initialize (Thomas) #2683232ec034bdc] - src: use sizeof(var) instead of sizeof(type) (Ben Noordhuis) #27038c537daf391] - src: apply clang-tidy rule bugprone-incorrect-roundings (gengjiawen) #2688580694949f2] - src: elevate v8::Task namespace (Juan José Arboleda) #26909aa6a741102] - src: replace c-style cast (gengjiawen) #26888f65cb75c74] - src: remove internal includes from node_crypto.h (Sam Roberts) #26966d0ee1a3dbb] - src: fix warning on mismatched fn signature (Sam Roberts) #26950fbdead7f35] - src: add missing uv_fs_req_cleanup() (cjihrig) #27004729e2f242f] - src: implement generic backend for process.env (Anna Henningsen) #26544d3840bcf0d] - src: allow per-Environment set of env vars (Anna Henningsen) #26544e776b013ad] - src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt (Joyee Cheung) #269350427354a98] - src: delete useless code in cares_wrap.cc (gengjiawen) #268156bfb17f528] - src: fix task release in cares_wrap.cc (gengjiawen) #26815c969731755] - src: use deleted function for class BaseObject (gengjiawen) #26815c824127756] - src: delete unused field in class ModuleWrap (gengjiawen) #26815ea7e2c0666] - src: tidy up include headers in env.cc (gengjiawen) #26815c1def0701e] - src: delete unreachable code in heap_utils.cc (gengjiawen) #26815c51cc9e85b] - src: apply clang-tidy rule modernize-make-unique (gengjiawen) #26493ab70c96a79] - src: refactor coverage connection (Joyee Cheung) #2651363e7cc7694] - src: forbid access to CLI options before bootstrapping is done (Joyee Cheung) #26476e6c1ad5901] - src: fix warnings around node_options (Refael Ackermann) #2628062f904974d] - src: refactor node options parsers to mitigate MSVC bug (Refael Ackermann) #26280b29afa212a] - (SEMVER-MINOR) stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989ea47189b40] - stream: do not unconditionally call\_read()onresume()(Anna Henningsen) #26965b359a7a7e5] - test: make module test pass with NODE_PENDING_DEPRECATION (Anna Henningsen) #270191b2a07855a] - test: remove test-trace-events-api-worker-disabled from flaky (Rich Trott) #27020ecac6547c0] - test: move test that creates 1Gb file to pummel (Rich Trott) #2705335119d60d9] - test: add IPv6 brackets but no port to test-dns (Rich Trott) #270068258f0704d] - test: remove unused triggerAsyncId param in test (Juan José Arboleda) #2680006dce392ba] - test: fix error code typo (cjihrig) #27024e5181f8dc4] - test: simplify for loop in test-buffer-zero-fill-cli.js (Juan José Arboleda) #267999330d7e4bf] - test: add known_issues test for fs.copyFile() (Rich Trott) #26939fd6381b056] - test: remove test-path-parse-6229.js from known issues (Ruben Bridgewater) #26913edad9afaf8] - test: move hasCrypto check (Ruben Bridgewater) #268582ef1bd97c6] - test: do not require flags when executing a file (Ruben Bridgewater) #26858a1cf7453d8] - test: refactor path parse test (Ruben Bridgewater) #2691280e845e787] - test: add test about unencrypted PKCS#8 private key for RSA (Daiki Ihara) #2689803bd649655] - test: show stderr on v8 coverage test failures (Joyee Cheung) #26513b24e45ab8d] - (SEMVER-MINOR) timers: deprecate active() and _unrefActive() (Jeremiah Senkpiel) #267603ff3070442] - tools: fixtest.py --time(Richard Lau) #270077cbe1214d0] - tools: update ESLint to 5.16.0 (cjihrig) #27005dc9ce86aaa] - tools: update dependencies in lint-md-cli-rollup (Daijiro Wachi) #268898798db3bf3] - url: add ws: and wss: to slashedProtocol set (Luigi Pinca) #2694112737b3789] - util:inspect()should not exceedbreakLength(Ruben Bridgewater) #269140f615d4216] - util: add subclass and null prototype support for errors in inspect (Ruben Bridgewater) #269231aa6e993e3] - util: fix map entries inspection (Ruben Bridgewater) #269181b08e622aa] - util: improve proxy inspection (Ruben Bridgewater) #2691921486e5c97] - util: extract uncurryThis function for reuse (ZYSzys) #23081169f3f7166] - util: requireisNativeErrorfrom internalBinding (ZYSzys) #230818bd7909d00] - worker: use copy of process.env (Anna Henningsen) #26544682b410581] - worker: allow execArgv and eval in combination (Anna Henningsen) #265335d9f819a14] - worker: remove usage of require('util') in worker_thread.js (toshi1127) #2681444450efa6b] - worker: remove usage of require('util') (toshi1127) #26810