console: fix class inheritance regression #20158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a return statement with new inside the function, extending Console class does not work when passing in just the stdout arg.
nodejs-github-bot
added
the
console
apapirovski
added
the
fast-track
|
Please 👍 this if you approve the fast-track. |
addaleax
approved these changes
Apr 19, 2018
lpinca
approved these changes
Apr 20, 2018
danbev
approved these changes
Apr 20, 2018
targos
approved these changes
Apr 20, 2018
joyeecheung
approved these changes
Apr 20, 2018
|
Landed in 700344e |
|
@jasnell this will need to be pulled into 10.0.0 |
apapirovski
added a commit
that referenced
this pull request
Apr 20, 2018
Due to a return statement with new inside the function, extending Console class does not work when passing in just the stdout arg. PR-URL: #20158 Fixes: #20157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
Due to a return statement with new inside the function, extending Console class does not work when passing in just the stdout arg. PR-URL: #20158 Fixes: #20157 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a return statement combined with new inside the function, extending Console class does not work when passing in just the stdout arg. This PR fixes it and needs to land for 10.0.0.
Fixes: #20157
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes