Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: alter ERR_INVALID_DOMAIN_NAME #19961

Closed
wants to merge 1 commit into from
Closed

errors: alter ERR_INVALID_DOMAIN_NAME #19961

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Member

@davidmarkclements davidmarkclements commented Apr 12, 2018 •
edited
Loading

changes the base instance for ERR_INVALID_DOMAIN_NAME
from Error to TypeError as a more accurate representation
of the error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 12, 2018
@vsemozhetbyt
Copy link
Contributor

Additionally corrects the grammar of the error message.

Seems obsolete?)

@vsemozhetbyt vsemozhetbyt added the http Issues or PRs related to the http subsystem. label Apr 12, 2018
errors: alter ERR_INVALID_DOMAIN_NAME
3bdd8e5 
changes the base instance for ERR_INVALID_DOMAIN_NAME
from Error to TypeError as a more accurate representation
of the error.
@davidmarkclements
Copy link
Member Author

@vsemozhetbyt it is - now removed from commit message

@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14290/

@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 15, 2018
@BridgeAR BridgeAR requested a review from a team April 15, 2018 21:49
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2018
@lpinca
Copy link
Member

lpinca commented Apr 16, 2018

This needs at least one more TSC approval before it can land.

@lpinca
Copy link
Member

lpinca commented Apr 16, 2018

cc: @nodejs/tsc

mcollina
mcollina approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
Copy link
Member

lpinca commented Apr 16, 2018

Landed in 345e3b2.

@lpinca lpinca closed this Apr 16, 2018
lpinca pushed a commit that referenced this pull request Apr 16, 2018
@lpinca
errors: alter ERR_INVALID_DOMAIN_NAME
345e3b2 
Changes the base instance for ERR_INVALID_DOMAIN_NAME from Error to
TypeError as a more accurate representation of the error.

PR-URL: #19961
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@jasnell
errors: alter ERR_INVALID_DOMAIN_NAME
afb4d55 
Changes the base instance for ERR_INVALID_DOMAIN_NAME from Error to
TypeError as a more accurate representation of the error.

PR-URL: #19961
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@davidmarkclements @vsemozhetbyt @jasnell @lpinca @mcollina @BridgeAR @trivikr @nodejs-github-bot